Refactor escrow contract: add new DataKey variant, enhance error hand… - #641
Closed
extolkom wants to merge 3 commits into
Closed
Refactor escrow contract: add new DataKey variant, enhance error hand…#641extolkom wants to merge 3 commits into
extolkom wants to merge 3 commits into
Conversation
…ling, and streamline arithmetic operations
|
@extolkom is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@extolkom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #374
Implemented SC-ESC-020 by tightening the escrow contract and adding deterministic integration coverage for the happy path. The update adds comprehensive escrow tests that simulate latency through ledger time, cover multiple client/freelancer scenarios, validate active escrow getters and balances, verify fee routing, and assert unauthorized state changes fail with the contract’s unauthorized error.
The change also fixes escrow-side compile risks by restoring missing storage/error definitions, using checked arithmetic for timestamp and balance calculations, cleaning duplicate definitions, and ensuring state-changing flows return consistently. Scope was kept to
contracts/escrow/src/lib.rsto minimize merge-conflict and CI risk.