Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 11 permission check fix #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rastafan
Copy link

Platforms affected

Android 11

Motivation and Context

On Android 11, plugin always returns error 20 (PERMISSION_DENIED_ERROR) on camera open.

Description

changed "getPermission" to return only READ_EXTERNAL_STORAGE o CAMERA + READ_EXTERNAL_STORAGE when called on Android 11 and above (but below android 13).
This was necessary to avoid ERROR 20 whenc hecking permission status on camera opening (permission for WRITE_EXTERNAL_STORAGE always returned -1)

Maybe this should be merged with the rest of the commit on the main cordova plugin project.

Testing

Tested on Android 11 Emulator

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

changed "getPermission" to return only READ_EXTERNAL_STORAGE o CAMERA + READ_EXTERNAL_STORAGE when called on Android 11 and above (but below android 13).
This was necessary to avoid ERROR 20 whenc hecking permission status on camera opening (permission for WRITE_EXTERNAL_STORAGE always returned -1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant