Fixes example JSON to contain duration#470
Merged
francinum merged 2 commits intoDaedalusDock:masterfrom Aug 11, 2023
Merged
Conversation
Also adds example comment for duration
Member
|
does the code verify it exists and scream if it doesnt? Also it does not say what unit of time the duration is in. |
Contributor
Author
francinum
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes the contents of the __EXAMPLE.json file for json music files to include duration by default, as it is required for files to properly play in the jukebox.
Done per @francinum 's request.
Why It's Good For The Game
Not player facing
Changelog
🆑 Gonenoculer5
fix: Modifies EXAMPLE.json to contain correct comment text relating to durations of music files.
/:cl: