Skip to content

Commit

Permalink
Fix error at cmake configuration time
Browse files Browse the repository at this point in the history
I get errors on the 'install' lines saying that it is required to
specify the destinations with CMake 3.13.
This is not required in newer versions apparently?
  • Loading branch information
slipher authored and illwieckz committed Jan 29, 2025
1 parent 3ef7ed1 commit af386c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions crnlib/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ add_library(${CRUNCH_LIBRARY_NAME} ${CRUNCH_DEFAULT_LIBRARY_TYPE} $<TARGET_OBJEC
set_property(TARGET ${CRUNCH_LIBRARY_NAME} PROPERTY POSITION_INDEPENDENT_CODE 1)

if (BUILD_SHARED_LIBS OR BUILD_STATIC_LIBCRN)
install(TARGETS ${CRUNCH_LIBRARY_NAME})
install(TARGETS ${CRUNCH_LIBRARY_NAME} DESTINATION lib)
endif()

if ((BUILD_SHARED_LIBS AND BUILD_STATIC_LIBCRN) OR (NOT BUILD_SHARED_LIBS AND BUILD_SHARED_LIBCRN))
Expand All @@ -224,5 +224,5 @@ if ((BUILD_SHARED_LIBS AND BUILD_STATIC_LIBCRN) OR (NOT BUILD_SHARED_LIBS AND BU
set_target_properties(${CRUNCH_OTHER_LIBRARY_NAME} PROPERTIES OUTPUT_NAME ${CRUNCH_LIBRARY_NAME})
endif()

install(TARGETS ${CRUNCH_OTHER_LIBRARY_NAME})
install(TARGETS ${CRUNCH_OTHER_LIBRARY_NAME} DESTINATION lib)
endif()
2 changes: 1 addition & 1 deletion crunch/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ add_executable(${CRUNCH_EXE_NAME} ${CRUNCH_SRCS})

target_link_libraries(${CRUNCH_EXE_NAME} ${CRUNCH_LIBRARY_NAME} ${CMAKE_THREAD_LIBS_INIT})

install(TARGETS ${CRUNCH_EXE_NAME})
install(TARGETS ${CRUNCH_EXE_NAME} DESTINATION bin)
set_property(TARGET ${CRUNCH_EXE_NAME} PROPERTY POSITION_INDEPENDENT_CODE 1)

0 comments on commit af386c1

Please sign in to comment.