Skip to content
This repository was archived by the owner on Oct 14, 2026. It is now read-only.

Feature/dependent filters - #401

Merged
Ishankoradia merged 8 commits into
mainfrom
feature/dependent-filters
Oct 9, 2026
Merged

Ishankoradia merged 8 commits into
mainfrom
feature/dependent-filters

Conversation

@NaveenCode

@NaveenCode NaveenCode commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Dependent (group) filters for dashboards

Summary

  • Adds a "Link filters" config modal to group same-table VALUE filters so selecting one narrows the others (with auto-drop when a selection becomes invalid).
  • Dashboard filter panel now renders a fixed "Linked filters" card at the top (edit, view, public, and report modes), with drag-reorder scoped separately within the linked group vs. independent filters.
  • Fixes: chart empty-state message ("No data for the selected filters") across Table, Pivot Table, and chart detail views; date filter not resetting when cleared via the clear-filter icon.
  • Merged with main.

Summary by CodeRabbit

  • New Features
    • Dashboard editors can link related filters and configure which filters narrow one another.
    • Filter options update based on selections in linked filters. If selected values are no longer available, they’re cleared; editors see a notice when options can’t be loaded.
    • Successful option loads show the number of available choices.
  • Bug Fixes
    • Empty charts now explain that selected filters returned no data and suggest changing or removing filters.
    • Clearing a date range now clears previously selected dates.

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webapp-v2 Ready Ready Preview Oct 9, 2026 9:36am UTC

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6cc19a6c-5a45-446a-afbe-101c3808d91c

📥 Commits

Reviewing files that changed from the base of the PR and between 74296b7 and 287efe1.


⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (20)
  • app/charts/[id]/ChartDetailClient.tsx
  • components/charts/TableChart.tsx
  • components/charts/__tests__/TableChart.test.tsx
  • components/charts/pivot-table/PivotTableChart.tsx
  • components/dashboard/__tests__/dashboard-filter-widgets.test.tsx
  • components/dashboard/chart-element-v2.tsx
  • components/dashboard/chart-element-view.tsx
  • components/dashboard/dashboard-builder-v2.tsx
  • components/dashboard/dashboard-filter-widgets.tsx
  • components/dashboard/dashboard-native-view.tsx
  • components/dashboard/datetime-filter-widget.tsx
  • components/dashboard/dependent-filters-config-modal.tsx
  • components/dashboard/filter-config-modal.tsx
  • components/dashboard/filter-element.tsx
  • components/dashboard/responsive-filters-section.tsx
  • components/dashboard/unified-filters-panel.tsx
  • constants/dashboard-filters.ts
  • hooks/api/useDashboards.ts
  • lib/__tests__/dashboard-filter-group-narrowing.test.ts
  • lib/dashboard-filter-utils.ts

 ___________________________________________________________________
< Your tests are like unicorns: frequently referenced, rarely seen. >
 -------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NaveenCode NaveenCode self-assigned this Oct 6, 2026
…te save button state, and refine success toast message
…DS and optimize filter preview URL construction
@Ishankoradia
Ishankoradia merged commit 6b40bbc into main Oct 9, 2026
5 of 6 checks passed
@Ishankoradia
Ishankoradia deleted the feature/dependent-filters branch October 9, 2026 09:44

This branch had an error being deployed

1 abandoned (outdated) and 1 active deployments
Preview — 287efe18 Deployed Oct 9, 2026 by vercel[bot]
staging — bc2dc3c4 Deployed Oct 9, 2026 by github-actions[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants