fix: use proper runId for paginated queries (#42)

* fix: runId was required in config * fix: runId replaced by existingRun.id Co-authored-by: Jérémy Torralba <[email protected]>
DamianOsipiuk · Oct 12, 2022 · ad427e3 · ad427e3
1 parent 07f257d
commit ad427e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -71,7 +71,7 @@ const prepareRun = async (
       );
     }
   } else if (existingRun) {
-    const tests = await getAllTests(testrailAPI, config);
+    const tests = await getAllTests(testrailAPI, existingRun.id);
     const currentCaseIds = tests?.map((test) => test.case_id) || [];
     const additionalDescription = "\n" + runDescription;
     const newDescription = existingRun.description
@@ -271,7 +271,7 @@ class TestcafeTestrailReporter {
     const { value: results } = await throwOnApiError(
       testrailAPI.addResultsForCases(runId, resultsToPush)
     );
-    const tests = await getAllTests(testrailAPI, this.config);
+    const tests = await getAllTests(testrailAPI, runId);
 
     if (this.config.uploadScreenshots) {
       await uploadScreenshots({

diff --git a/src/utils/testrail-getResults.ts b/src/utils/testrail-getResults.ts
@@ -21,16 +21,16 @@ export const getAllCases = async (testrailAPI: TestRail, config: Config) => {
   return cases;
 };
 
-export const getAllTests = async (testrailAPI: TestRail, config: Config) => {
+export const getAllTests = async (testrailAPI: TestRail, runId: number) => {
   let { value: testsResult } = await throwOnApiError(
-    testrailAPI.getTests(config.runId)
+    testrailAPI.getTests(runId)
   );
   let tests = testsResult.tests || [];
   let offsetVal = 0;
   while (testsResult._links.next !== null) {
     offsetVal += 250;
     ({ value: testsResult } = await throwOnApiError(
-      testrailAPI.getTests(config.runId, { offset: offsetVal })
+      testrailAPI.getTests(runId, { offset: offsetVal })
     ));
     tests = tests.concat(testsResult.tests);
   }