numaGetCount(): make sure surrounding code/variables are properly pre…

…-initialized to cope with the fringe case where the NUMA histogram is empty (count = 0) (Discovered through code review & accidental misuse in vitro (when I fed numaHistogramGetValFromRank() an empty histogram by accident).)
DanBloomberg · Aug 24, 2023 · 9d7ecbe · 9d7ecbe
1 parent eaaf52f
commit 9d7ecbe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/graphics.c b/src/graphics.c
@@ -1152,6 +1152,7 @@ PTA       *pta1, *pta2, *ptad;
 
         /* Generate the plot points */
     pta1 = ptaCreate(n);
+    maxw = maxh = 0;       
     for (i = 0; i < n; i++) {
         numaGetFValue(na, i, &val);
         if (orient == L_HORIZONTAL_LINE) {

diff --git a/src/numafunc2.c b/src/numafunc2.c
@@ -1613,6 +1613,7 @@ l_float32  startval, binsize, rankcount, total, sum, fract, val;
     numaGetSum(na, &total);
     rankcount = rank * total;  /* count that corresponds to rank */
     sum = 0.0;
+    val = 0.0;
     for (i = 0; i < n; i++) {
         numaGetFValue(na, i, &val);
         if (sum + val >= rankcount)