minor Numa safety patches #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…histogram is empty (count = 0) (Discovered through code review.)
…-initialized to cope with the fringe case where the NUMA histogram is empty (count = 0) (Discovered through code review & accidental misuse in vitro (when I fed numaHistogramGetValFromRank() an empty histogram by accident).)
There was a problem hiding this comment.
colorquant1.c
this return leaks the index tables. Easiest is to swap the two sections.
Should probably initialize octarray and colorarray to NULL when declared above. If that is done, then you can goto cleanup_arrays if numaGetCount() fails without swapping sections.
|
merged; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also the commit messages... I hit upon these thanks to my own misuse of one these APIs (unintentionally feeding it a NUMA array of zero length) and I got some random weird results with MSVC2022, then I investigated and found
numaGetCount() == 0was not reckoned with. Followed up that one with an overall code review and fixed all the spots where the code for thecount == 0scenario was either non-trivial or would potentially produce random/garbage results.(For example, a zero-length calloc on my system is a hard fail because it's way too often indicative of faulty coding somewhere, so I won't wait for
LEPT_CALLOCto b0rk with a NULL return. This is more... pedantic than one may expect on Linuxes in general.)