Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS specific directory instead of /tmp #713

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

stweil
Copy link
Collaborator

@stweil stweil commented Aug 31, 2023

In addition, a trivial compiler warning was fixed by using an ANSI C function prototype.

@stweil
Copy link
Collaborator Author

stweil commented Aug 31, 2023

These modifications were inspired by pull request #709 which is replaced here. All tests pass on macOS:

============================================================================
Testsuite summary for leptonica 1.84.0
============================================================================
# TOTAL: 146
# PASS:  146
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

@DanBloomberg
Copy link
Owner

Thank you. Really nice to have this resolved.
Good to see the test suite passes on macOS.
All looks good except for comments at lines 2395 and 2345.

@stweil
Copy link
Collaborator Author

stweil commented Sep 1, 2023

All looks good except for comments at lines 2395 and 2345.

Please help me. How should those comments look like?

@DanBloomberg DanBloomberg merged commit d0fa51c into DanBloomberg:master Sep 1, 2023
9 checks passed
@DanBloomberg
Copy link
Owner

Not a big deal; can be modified later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants