Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for build and test on macOS #716

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

stweil
Copy link
Collaborator

@stweil stweil commented Sep 1, 2023

No description provided.

@stweil
Copy link
Collaborator Author

stweil commented Sep 1, 2023

See this example for the new action.

@DanBloomberg DanBloomberg merged commit eeefd24 into DanBloomberg:master Sep 1, 2023
9 checks passed
@DanBloomberg
Copy link
Owner

Elegant!!

I looked at the example, and saw it did 147 tests. I've been getting 146 when run locally using alltests_reg.
Comparing the set, I found that numa3_reg.c had been omitted from alltests_reg, for no good reason. So I'll add it.

@stweil stweil deleted the ci branch September 1, 2023 17:47
@stweil
Copy link
Collaborator Author

stweil commented Sep 1, 2023

@DanBloomberg, I wonder whether the new action really should be triggered by every pull request and git push. In addition it can be triggered manually by project maintainers (url). Each action run uses two CPU cores for 12 minutes, one for macOS 12 and one for macOS 13.

Maybe it would be sufficient to run only on macOS 13 by default, so macOS 12 would only be tested when that was requested manually. What do you think?

@DanBloomberg
Copy link
Owner

Running by default only with macOS 13 is fine with me.

Considering possible overuse of github resources, what do you think about the fuzzing that is run on every git push? (I don't know if it is run with PRs)

@stweil
Copy link
Collaborator Author

stweil commented Sep 1, 2023

The fuzzing action is only triggered by pull requests, see the code. It typically runs for about 30 minutes (see history). That looks like a waste of resources, for example electrical energy, because Google's OSS-Fuzz also runs fuzzers for Leptonica (not only for a few minutes which won't find issues, but really long) and reports build errors by e-mail. @AdamKorcz, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants