Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pix{Read,Write}MemJp2k work via direct memory access #732

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Make pix{Read,Write}MemJp2k work via direct memory access #732

merged 2 commits into from
Feb 6, 2024

Commits on Feb 5, 2024

  1. Make pix{Read,Write}MemJp2k work via direct memory access. 

    * On platforms lacking open_memstream(), pix{Read,Write}MemJp2k()
  worked via a temporary file, but this overhead is unnecessary
  as openjpeg2000's opj_stream allows one to read/write directly
  from a memory buffer by supplying it with appropriate callbacks.
* This commit makes pix{Read,Write}MemJp2k() use this more direct
  mechanism on all platforms.
* In addition, since pixReadStreamJp2k() always read the whole
  stream into memory when it called fgetJp2kResolution(),
  this commit saves a bit of compute resources by in effect making
  pixReadStreamJp2k() into a wrapper for pixReadMemJp2k().
    @atykhyy
    atykhyy committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cfc875a View commit details
    Browse the repository at this point in the history

  2. Fix errors introduced by patch merge

    @atykhyy
    atykhyy committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    863a608 View commit details
    Browse the repository at this point in the history