Replace sh by bash for reg_wrapper.sh and fix test for working gnuplot #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some older versions of /bin/sh don't work. This was noticed in a test on Solaris 11.4 (SPARC) with sh (AT&T Research) 93u+ 2012-08-01. Instead of using /bin/bash the script now finds bash with /usr/bin/env, so it will use the latest bash on systems like macOS. Signed-off-by: Stefan Weil <[email protected]>
`gnuplot -e "set terminal png"` does not return an error if the command fails, but prints an error message. So instead of checking for an error the test now checks for a non-empty output. This fixes `make check` on hosts with a gnuplot which does not support `set terminal png`. Signed-off-by: Stefan Weil <[email protected]>
stweil
changed the title
|
Nice!! I'm signing off. Feel free to push to head when the tests complete. |
It's the very latest gnuplot code, but compiled on Solaris without libpng. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older versions of /bin/sh don't work.
This was noticed in a test on Solaris 11.4 (SPARC) with sh (AT&T Research) 93u+ 2012-08-01.
Instead of using /bin/bash the script now finds bash with /usr/bin/env, so it will use the latest bash on systems like macOS.
Fix also the test for a working gnuplot.
gnuplot -e "set terminal png"does not return an error if the command fails, but prints an error message.So instead of checking for an error the test now checks for a non-empty output.
This fixes
make checkon hosts with a gnuplot which does not supportset terminal png.