Skip to content

minor fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-AVE wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

minor fix #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 2 additions & 60 deletions .github/workflows/build-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:
branches: [ develop ]
pull_request:
branches: [ develop ]
#schedule:
# # This example triggers the workflow every day at 5:30 and 17:30 UTC:
# # * is a special character in YAML so you have to quote this string
# - cron: '30 5,17 * * *'

jobs:
build:
Expand All @@ -21,12 +17,7 @@ jobs:
node-version: '14.x'
- name: Install dependencies
run: npm ci
- name: Run typescript lint and format check
run: npm run lint:ts
- name: Run styles lint and format check
run: npm run lint:css
#- name: Run tests
# run: npm test
# Add tests and linting here
deploy:
needs: build
runs-on: ubuntu-latest
Expand All @@ -38,53 +29,4 @@ jobs:
node-version: '14.x'
- name: Install dependencies
run: npm ci
#- name: Use a secret
# run: echo "My guilty pleasure is $SECRET, but i pretend it is $not-a-secret"
# env:
# SECRET=${{ secret.PASSWORD }}
# not-a-secret=Eurovision
- name: Build
run: npm run build
#- name: Deploy 🚀
# if: github.ref == 'refs/heads/develop'
# uses: JamesIves/github-pages-deploy-action@4.1.4
# with:
# branch: gh-pages
# folder: dist
#security:
# needs: deploy
# runs-on: ubuntu-latest
# steps:
# - name: Test for public javascript library vulnerabilities on your site
# uses: lirantal/is-website-vulnerable@master
# with:
# scan-url: " https://<you-username>.github.io/"

# push-to-docker:
# if: github.event_name != 'pull_request'
# needs: build
# name: Push Docker image to Docker Hub
# runs-on: ubuntu-latest
# steps:
# - name: Check out your code
# uses: actions/checkout@v2

# - name: Log in to Docker Hub
# uses: docker/login-action@v1
# with:
# username: ${{ secrets.DOCKER_USERNAME }}
# password: ${{ secrets.DOCKER_PASSWORD }}

# - name: Extract metadata (tags, labels) for Docker
# id: meta
# uses: docker/metadata-action@v3
# with:
# images: my-docker-hub-namespace/my-docker-hub-repository

# - name: Build and push Docker image
# uses: docker/build-push-action@v2
# with:
# context: .
# push: true
# tags: ${{ steps.meta.outputs.tags }}
# labels: ${{ steps.meta.outputs.labels }}
# Add deploy to Github pages here! Hot tip - The solution is in the Readme
2 changes: 1 addition & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="format-detection" />
<title>Git Actions</title>
<title>Github Actions</title>
</head>
<body>
<div id="app-root" class="app-root"></div>
Expand Down