This repository was archived by the owner on Mar 11, 2023. It is now read-only.
add custom error handler #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbalonperin
commented
Mar 16, 2018
| response.entity.withoutSizeLimit.dataBytes | ||
| .via(Framing.delimiter(ByteString("\r\n"), Int.MaxValue).async) | ||
| .filter(_.nonEmpty) | ||
| .via(killSwitch.flow) | ||
| .map(data => unmarshalStream(data, f)) | ||
| .recoverWithRetries(attempts = 3, { |
There was a problem hiding this comment.
Ideally, the number of attempts should be configurable.
| package com.danielasfregola.twitter4s.http.clients.streaming | ||
|
|
||
| object ErrorHandler { | ||
| def default: PartialFunction[Throwable, Unit] = { |
There was a problem hiding this comment.
As discussed, could you change it to ignore?
DanielaSfregola
approved these changes
Mar 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 94.22% 94.23% +0.01%
==========================================
Files 72 73 +1
Lines 1143 1145 +2
Branches 12 13 +1
==========================================
+ Hits 1077 1079 +2
Misses 66 66
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #144