This repository has been archived by the owner on Mar 11, 2023. It is now read-only.
Make TwitterRestClient constructor accessible to allow app-only-auth hack #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hack Following on from DanielaSfregola#237 (comment) this is the smallest change required to get the constructor-overriding hack in this gist to work: https://gist.github.com/rtyley/dc341992a6104f4b499834fd2d10dfad
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 76 76
Lines 1173 1173
Branches 12 12
=======================================
Hits 1106 1106
Misses 67 67
Continue to review full report at Codecov.
|
DanielaSfregola
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Hi @rtyley,
thanks for your contribution! Will try to do a patch release as soon as possible (version 6.0.1?).
LGTM
|
I have now released twitter4s 6.0.1 with this patch -- it should be in maven central in a few minutes |
|
Great! Thanks so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #237 (comment) this is the smallest change required to get the constructor-overriding hack in this gist to work:
https://gist.github.com/rtyley/dc341992a6104f4b499834fd2d10dfad