Skip to content
This repository was archived by the owner on Mar 11, 2023. It is now read-only.

#236 Fixed rate information parsing#268

Merged
DanielaSfregola merged 1 commit intomasterfrom
instant_parsing_issue
Sep 23, 2019
Merged

#236 Fixed rate information parsing#268
DanielaSfregola merged 1 commit intomasterfrom
instant_parsing_issue

Conversation

@DanielaSfregola
Copy link
Copy Markdown
Owner

I believe this caused #236: we were unable to parse Instant from long and int

@DanielaSfregola DanielaSfregola added this to the 6.2 milestone Sep 23, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 23, 2019

Codecov Report

Merging #268 into master will decrease coverage by 1.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   94.28%   92.68%   -1.61%     
==========================================
  Files          76       77       +1     
  Lines        1173     1176       +3     
  Branches       12       10       -2     
==========================================
- Hits         1106     1090      -16     
- Misses         67       86      +19
Impacted Files Coverage Δ
...ola/twitter4s/http/serializers/CustomFormats.scala 100% <ø> (ø) ⬆️
...egola/twitter4s/http/serializers/JsonSupport.scala 91.66% <100%> (+0.75%) ⬆️
...itter4s/http/clients/streaming/TwitterStream.scala 20% <0%> (-80%) ⬇️
...ter4s/http/clients/streaming/StreamingClient.scala 65% <0%> (-35%) ⬇️
...sfregola/twitter4s/http/clients/CommonClient.scala 30% <0%> (-30%) ⬇️
...regola/twitter4s/processors/TwitterProcessor.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4085e...a5baf1e. Read the comment docs.

@DanielaSfregola
Copy link
Copy Markdown
Owner Author

LGTM

@DanielaSfregola DanielaSfregola merged commit 3b89c54 into master Sep 23, 2019
@DanielaSfregola DanielaSfregola deleted the instant_parsing_issue branch June 19, 2021 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant