withenergy construction option, get_homes() get_devices() get_energy() methods

[lupus78]

withenergy construction option, if True, the ?withEnergy=1 query is used on /content/ endpoint.

get_homes()
get_devices()
get_energy() methods

I just wanted to monitor the energyWh data points, ended up adidng a withenergy parameter to contrstuctor, and the about 3 getters

[Danielhiversen]

Is that different than the energy data from fetch_energy_info?

pyAdax/adax/__init__.py

Line 141 in f0748e7

async def fetch_energy_info(self):

[lupus78]

Is that different than the energy data from fetch_energy_info?

pyAdax/adax/__init__.py

Line 141 in f0748e7

async def fetch_energy_info(self):

Not the same. This one is a log for each device and aggregate by hours. The one with the content endpoint is by Room and for the last hour.

As you can see the Blue line is from the content?withEnergy endpoint. I query it every 10 minutes, and you can see it's progressing throughout the hour and resets.
The pink line is from the energy_log (I also ran that 10 minutes and always pick the last data), I think it's shifted this was, but you can see it almost alines with the hourly tops.

[Danielhiversen]

So the energy data is then stored in self._devices ?

[lupus78]

So the energy data is then stored in self._devices ?

yes

[Danielhiversen]

I would suggest to add an include_energy parameter and then remove self.withenergy

[lupus78]

In the current structure that would mean to pass it down from get_room and update

[Danielhiversen]

I think it would be better to not do self.update() in all these functions. Should be possible to get self._homes without forcing an update.
(Should not had self.update() in get_rooms either)

[lupus78]

I didn't wanted to such refactor. Imho, the cleanest would be to have functions which are 1-on-1 with the API endpoints.