-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Studio Iguana | 2023.2.1 #505
base: master
Are you sure you want to change the base?
Conversation
I can't merge, changing compile SDK and gradle config is not simple, because it's make so many trouble with Jitpack. I know that will take me a whole day to fix it. I haven't enought time right now, I will update SDK compiler in the future. |
No problem, take your. I am aware of Jitpack issues. |
You have check the Jitpack intégration ? On previous PR of SDK compile update, I had so many trouble with Jitpack. Now, I'm afraid of merging PR. 😅 |
- JDK 17 - SDK 34 - v3.4.0 - Find TODOs for issue
Please verify build.gradle line 55. I had a problem with this but after commenting that out it worked.
|
that's a part why I'm scared to merge. There is a lot of change in the gradle config ^^' |
Yas, I am aware of it. So I do understand the scary part. 👍 I will update the PR if I can figure out that. Till then hold merging the PR |
- Jitpack fix
Okey, The good news is Jitpack issue also fixed. Now I am able to import
|
I think it is good to go. You can merge now after some verification. I am sure there will no Jitpack issue after my last commit. |
- Updated README.md
@vikrammani-t2s Thanks for the approval. I need write access to merge it. |
Updated project to run on latest Android Studio Iguana