Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Studio Iguana | 2023.2.1 #505

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

arnab-kundu
Copy link

Updated project to run on latest Android Studio Iguana

@DantSu
Copy link
Owner

DantSu commented Mar 16, 2024

I can't merge, changing compile SDK and gradle config is not simple, because it's make so many trouble with Jitpack. I know that will take me a whole day to fix it. I haven't enought time right now, I will update SDK compiler in the future.

@DantSu DantSu closed this Mar 16, 2024
@arnab-kundu
Copy link
Author

No problem, take your. I am aware of Jitpack issues.
I have forked this repository and updated compile SDK and gradle config for Android Studio Iguana and when I found all working fine after spending a whole day, I thought of helping out by creating a Pull Request.

@DantSu
Copy link
Owner

DantSu commented Mar 17, 2024

You have check the Jitpack intégration ? On previous PR of SDK compile update, I had so many trouble with Jitpack. Now, I'm afraid of merging PR. 😅

@arnab-kundu
Copy link
Author

Yes I did. It should be fine. Because when I run a build in Jitpack that succeeded. Attached screenshot of Jitpack.
Screenshot (52)
Screenshot (53)

 - JDK 17
 - SDK 34
 - v3.4.0
 - Find TODOs for issue
@DantSu DantSu reopened this Mar 17, 2024
@arnab-kundu
Copy link
Author

arnab-kundu commented Mar 17, 2024

Please verify build.gradle line 55. I had a problem with this but after commenting that out it worked.

afterEvaluate {
    publishing {
        publications {
            release(MavenPublication) {
                 .......
                 afterEvaluate {
                     from components.release // TODO verify this
                 }
            }
      }
}

@DantSu
Copy link
Owner

DantSu commented Mar 17, 2024

that's a part why I'm scared to merge. There is a lot of change in the gradle config ^^'

@arnab-kundu
Copy link
Author

Yas, I am aware of it. So I do understand the scary part. 👍 I will update the PR if I can figure out that. Till then hold merging the PR

@arnab-kundu
Copy link
Author

Okey, The good news is Jitpack issue also fixed. Now I am able to import EscPosPrinter in other projects after adding this dependency.

implementation 'com.github.arnab-kundu:ESCPOS-ThermalPrinter-Android:560dcb3814'

@arnab-kundu
Copy link
Author

I think it is good to go. You can merge now after some verification. I am sure there will no Jitpack issue after my last commit.

@arnab-kundu
Copy link
Author

In the last build .aar file was missing. You can find the differences in the screenshots.
Screenshot (53)
Screenshot (54)

@arnab-kundu
Copy link
Author

@vikrammani-t2s Thanks for the approval. I need write access to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants