fix(logging): warn only if publishing tasks get executed

DanySK · Nov 27, 2021 · d5cf58d · d5cf58d
1 parent cae4c4e
commit d5cf58d
Showing 1 changed file with 26 additions and 11 deletions.
diff --git a/src/main/kotlin/org.danilopianini.gradle.mavencentral/Configuration.kt b/src/main/kotlin/org.danilopianini.gradle.mavencentral/Configuration.kt
@@ -55,17 +55,13 @@ fun Project.configureRepository(repoToConfigure: Repository) {
                 mavenArtifactRepository.credentials { credentials ->
                     credentials.username = repoToConfigure.user.orNull
                     credentials.password = repoToConfigure.password.orNull
-                    credentials.username ?: project.logger.warn(
-                        "No username configured for repository {} at {}.",
-                        repoToConfigure.name,
-                        repoToConfigure.url,
-                    )
-                    credentials.password ?: project.logger.warn(
-                        "No password configured for user {} on repository {} at {}.",
-                        repoToConfigure.user,
-                        repoToConfigure.name,
-                        repoToConfigure.url,
-                    )
+                }
+                tasks.withType(PublishToMavenRepository::class) {
+                    if (it.repository == mavenArtifactRepository) {
+                        it.doFirst {
+                            warnIfCredentialsAreMissing(repoToConfigure)
+                        }
+                    }
                 }
             }
         }
@@ -100,6 +96,7 @@ private fun Project.configureNexusRepository(repoToConfigure: Repository, nexusU
                 }
             }
             publishTask.doFirst {
+                warnIfCredentialsAreMissing(repoToConfigure)
                 publishTask.repository.url = nexus.repoUrl
             }
             publishTask.publication = publication
@@ -123,3 +120,21 @@ private fun Project.configureNexusRepository(repoToConfigure: Repository, nexusU
         }
     }
 }
+
+private fun Project.warnIfCredentialsAreMissing(repository: Repository) {
+    if (repository.user.orNull == null) {
+        logger.warn(
+            "No username configured for repository {} at {}.",
+            repository.name,
+            repository.url,
+        )
+    }
+    if (repository.password.orNull == null) {
+        logger.warn(
+            "No password configured for user {} on repository {} at {}.",
+            repository.user.orNull,
+            repository.name,
+            repository.url,
+        )
+    }
+}