Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception for bad unit number #31

Closed
wants to merge 1 commit into from
Closed

Fix exception for bad unit number #31

wants to merge 1 commit into from

Conversation

DatCaldo
Copy link

Instead of raising an error, simply print a warning and skip the out of bounds number

@DatCaldo
Fix exception for bad unit number
78c2ff3 
Instead of raising an error, simply print a warning and skip the out of bounds number
@MikuAuahDark
Copy link
Contributor

After digging through School Idol Tomodachi API, I think I have a better solution to solve this. SIT API has game_id field when querying card info, which directly translates to unit_id in the in-game database.

@DatCaldo DatCaldo deleted the DatCaldo branch October 16, 2024 04:36
@MikuAuahDark
Copy link
Contributor

The proper fix should be in 01ad332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DatCaldo @MikuAuahDark