Skip to content

Reimplements permanent ghouling and embracing (EXCEPT FOR THE DISCIPLINE BITS)#738

Open
lpeapnni wants to merge 3 commits intoDarkPack13:masterfrom
lpeapnni:dev/bhurhurbhu
Open

Reimplements permanent ghouling and embracing (EXCEPT FOR THE DISCIPLINE BITS)#738
lpeapnni wants to merge 3 commits intoDarkPack13:masterfrom
lpeapnni:dev/bhurhurbhu

Conversation

@lpeapnni
Copy link
Contributor

@lpeapnni lpeapnni commented Feb 27, 2026

About The Pull Request

Reimplements the code to handle permanent embracing/ghouling. As of right now, the discipline bits still need to be implemented.

embracing:
image
image

ghouling:
image
image

Why It's Good For The Game

Bro

Changelog

🆑
code: Reimplemented permanent ghouling and embracing
/:cl:

@lpeapnni lpeapnni requested a review from a team as a code owner February 27, 2026 07:49
Copy link
Contributor

@chazzyjazzy chazzyjazzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine im just wondering if its the case that the childe's morality path and score in it is the same as the sire's. kinda breaks things too considering a player's morality path score is the sum of their relevant virtues (for ex, humanity has conscience and self control, so 3 in each gives humanity 6), which may deviate from the sire's selected virtues.

@lpeapnni
Copy link
Contributor Author

lpeapnni commented Feb 27, 2026

looks fine im just wondering if its the case that the childe's morality path and score in it is the same as the sire's. kinda breaks things too considering a player's morality path score is the sum of their relevant virtues (for ex, humanity has conscience and self control, so 3 in each gives humanity 6), which may deviate from the sire's selected virtues.

just gave it a quick test; the morality path is the same as the sires (as intended), but the score isnt the same. is the score supposed to be the same as the sires?

@chazzyjazzy
Copy link
Contributor

looks fine im just wondering if its the case that the childe's morality path and score in it is the same as the sire's. kinda breaks things too considering a player's morality path score is the sum of their relevant virtues (for ex, humanity has conscience and self control, so 3 in each gives humanity 6), which may deviate from the sire's selected virtues.

just gave it a quick test; the morality path is the same as the sires (as intended), but the score isnt the same. is the score supposed to be the same as the sires?

No, a character's starting morality score, according to the TT, afaik, is the sum of their relevant virtues

for ex, Humanity has the virtues conscience and self control

So if someone were to be embraced, just copying their sires is fine, but if it carries over to the statsheet, it may break some things

May want to just set them to the sum of their virtues, and set them to humanity from the jump, so theyd be morality_path humanity and score would be STAT_CONSCIENCE + STAT_SELF_CONTROL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants