Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #3610 minBufferToKeep #3611

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

orange4glace
Copy link
Contributor

#3610

Any thoughts please!

@dsilhavy
Copy link
Collaborator

Can we solve this problem by using the segment duration rather than a static value? Based on your description in #3610 I assume that the Tizen TV clears everything up to the next GoP/segment boundary as soon as you want to clear a buffer range that does not correspond to a segment boundary?

Consequently, if we keep at least one segment duration + SAFETY_OFFSET (maybe sth like 500ms) in the buffer it should not clear everything and cause a gap?

@orange4glace
Copy link
Contributor Author

orange4glace commented Apr 17, 2021

@dsilhavy Oh I didn't think about that. That would be more reasonable!
Since there's a code which is getting the executed fragment within the currentTime, I just added BUFFER_RANGE_CALCULATION_THRESHOLD (which is 500ms, and I'm not sure this is the best name?) as a safety guard.
Please squash & merge if it looks great or I'll open a new PR to clean up the commit history.

@Douina
Copy link

Douina commented Apr 18, 2021

please where I can find the source code the dynamic algorithm that groups bola and troughtput

@orange4glace
Copy link
Contributor Author

please where I can find the source code the dynamic algorithm that groups bola and troughtput

Maybe you mean this, https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/controllers/AbrController.js#L490

@Douina
Copy link

Douina commented Apr 18, 2021

yes,but this is just the update function,i search for the real one
thanks you

@dsilhavy
Copy link
Collaborator

@orange4glace I would prefer to only apply this offset in case a QUOTA_EXCEEDED_ERROR error occurs. Could you do it that way and rebase your change against the latest development branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants