Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle Emulation Prevention Bytes in CEA-608 parsing #3719

Conversation

grabofus
Copy link

Addresses #3679

@grabofus grabofus changed the title Fix: CEA-608 emulation prevention byte parsing Fix: handle Emulation Prevention Bytes in CEA-608 parsing Jul 29, 2021
@dsilhavy dsilhavy modified the milestones: 4.0.1, 4.1.0 Jul 30, 2021
@dsilhavy dsilhavy modified the milestones: 4.1.0, 4.1.1 Sep 20, 2021
@dsilhavy dsilhavy modified the milestones: 4.2.0, 4.3.0 Nov 19, 2021
@dsilhavy dsilhavy modified the milestones: 4.2.1, 4.3.0 Dec 20, 2021
@dsilhavy dsilhavy modified the milestones: 4.3.0, 4.3.1 Feb 14, 2022
@dsilhavy dsilhavy modified the milestones: 4.4.0, 4.4.1 Apr 14, 2022
@dsilhavy dsilhavy modified the milestones: 4.4.1, 4.5.0 Jul 15, 2022
@dsilhavy dsilhavy modified the milestones: 4.5.0, 4.6.0 Sep 20, 2022
@dsilhavy dsilhavy removed this from the 4.5.1 milestone Oct 13, 2022
Copy link
Contributor

@tobbee tobbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is copied from the DASH-IF cea608.js repo, so it should rather be a PR towards that repo, and then it should be updated here by including an updated version.

I haven't looked at that repo for a long time, but I just did, so I'll look at this at this as well, once it's sent there.

Removing start code emulation preventions bytes is apparently a lacking feature in cea608.js so it is a good thing to get that fixed.

@tobbee
Copy link
Contributor

tobbee commented Nov 16, 2022

@dsilhavy I made a ticket in cea608.js to make a proper NPM package so that the code can be imported in a better way.
Dash-Industry-Forum/cea608.js#4

@dsilhavy
Copy link
Collaborator

Thank you @tobbee .

@dsilhavy dsilhavy added this to the 5.0.0 milestone Aug 9, 2023
@dsilhavy
Copy link
Collaborator

@littlespex Do you know if this fix will be included in the CEA-608 implementation of the CML?

@littlespex
Copy link
Contributor

We will add this along with the Dash-Industry-Forum/cea608.js#3

agajassi added a commit to streaming-video-technology-alliance/common-media-library that referenced this pull request Jun 5, 2024
agajassi added a commit to streaming-video-technology-alliance/common-media-library that referenced this pull request Jun 5, 2024
Ported over changes from Dash-Industry-Forum/dash.js#3719

Signed-off-by: Agajan Jumakuliyev <[email protected]>
agajassi added a commit to cbsinteractive/dash.js that referenced this pull request Jun 21, 2024
Switching to Cta608Parser from common-media-library. Also includes changes that fixes emulation prevention bytes in cea-608 parsing. See Dash-Industry-Forum#3719
dsilhavy pushed a commit that referenced this pull request Jul 1, 2024
* Delete cea608-parser.js

Deleted this since we are now using Cta608Parser from common-media-library instead

* Update MediaPlayer.js

setting Cta608Parser from comon-media-library for adapter to use

* Update TextSourceBuffer.js

Switching to Cta608Parser from common-media-library. Also includes changes that fixes emulation prevention bytes in cea-608 parsing. See #3719

* Update package.json

new dependency for common-media-library version 0.7.0

* Update package-lock.json

* Update dash.DashAdapter.js

correcting unit test for the parser

* Update package.json

* Update package-lock.json

* Update package.json

* Update package-lock.json

* Update webpack.config.js

Configured polyfill for timers to resolve build issues related to xml2js dependency

* Update webpack.config.js

* Update package.json

* Update package-lock.json

* Update package.json

* Update package-lock.json

* fix: missing karam dep

---------

Co-authored-by: Casey Occhialini <[email protected]>
@dsilhavy
Copy link
Collaborator

dsilhavy commented Jul 1, 2024

This was addressed in #4522 . Thanks for the PR, closing this.

@dsilhavy dsilhavy closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants