task/cml-xml-parse#4719
Merged
dsilhavy merged 28 commits intoDash-Industry-Forum:developmentfrom Jun 2, 2025
Merged
Conversation
nigelmegitt
reviewed
Mar 17, 2025
Contributor
|
Would be helpful to explain the motivation for this change, given there's no associated issue. As I recall, one of the reasons for switching to tXml was performance-related. Have there been any performance comparisons done between tXml and CML? |
Contributor
Author
The PR description has been updated. In short, this is just the tXml function, now actively maintained by CML. |
…sh.js into task/xml-parse # Conflicts: # package-lock.json # package.json
dsilhavy
requested changes
May 15, 2025
Contributor
Author
dsilhavy
requested changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace tXml with CML's
parseXmlfunction.This change has been discussed previously on the monthly calls, but the summary is:
The
tXmllibrary is no longer supported/maintained, but is used by player libraries likedash.jsandshaka-player. Like many other features, both projects copied the source code into their respective repos and maintained changes separately. The original library code, and the changes made by the players, have been moved to the Common Media Library. This PR:dash.jsspecific functionality into a singleprocessXmlfunction.Here is the original CML issue:
streaming-video-technology-alliance/common-media-library#125