Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in ParallelForEachAsync when exceptions are thrown #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danylofitel
Copy link
Contributor

@danylofitel danylofitel commented Apr 21, 2020

Not resetting exception list to null in ReadExceptions, so that in case multiple tasks are finishing at the same time they will all read a non-empty list of exceptions.

Returning a copy of exception list from ReadExceptions to prevent concurrent reads by CompleteLoopNow and writes by tasks still running in case the loop was canceled.

…se multiple tasks are finishing at the same time they will both read a non-empty list of exceptions.

Returning a copy of exception list from ReadExceptions to prevent concurrent reads by CompleteLoopNow and writes by tasks still running in case the loop was canceled.
@danylofitel danylofitel changed the title Not resetting exception list to null in ParallelForEachContext.ReadExceptions Race condition in ParallelForEachAsync when exceptions are thrown Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant