Repository navigation
feat: remove visions dependency - #1887
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Tracing can mutate inference state and alter type-selection paths, while the date checks misclassify columns containing missing-date strings, losing date statistics and missing-value counts.
2 open issues
What changed in this PR
Replaces visions with a built-in type system to reduce dependency maintenance and licensing concerns while supporting profiling and custom types.
Changes:
- Adds deterministic type precedence, inference tracing, and single-pass inference and casting.
- Migrates report handlers and tests to the built-in types, with new reference data and snapshot tooling.
- Removes the dependency and updates type-inference documentation.
| File | Description |
|---|---|
| tests/unit/typeset_test_utils.py | Adds local membership, inference, and conversion helpers. |
| tests/unit/typeset_sequences.py | Adds independent reference series. |
| tests/unit/test_utils.py | Removes the obsolete visions workaround. |
| tests/unit/test_typeset_precedence.py | Tests precedence, structure, and handler inheritance. |
| tests/unit/test_typeset_default.py | Migrates default typeset tests to local helpers. |
| tests/unit/test_typeset_custom.py | Migrates custom typeset tests to local helpers. |
| tests/typeset_snapshot.py | Adds inference snapshot recording and comparison. |
| src/data_profiling/profile_report.py | Adopts the built-in typeset interface. |
| src/data_profiling/model/typeset.py | Defines built-in profiling types and precedence. |
| src/data_profiling/model/typeset_relations.py | Uses local null handling and revises date inference. |
| src/data_profiling/model/typeset_base.py | Implements relations, traversal, casting, and tracing. |
| src/data_profiling/model/summary.py | Updates summary interfaces to built-in typesets. |
| src/data_profiling/model/summarizer.py | Updates summarizer type interfaces. |
| src/data_profiling/model/spark/summary_spark.py | Uses schema-based Spark type detection. |
| src/data_profiling/model/pandas/summary_pandas.py | Combines inference and casting into one traversal. |
| src/data_profiling/model/handler.py | Composes handlers through the built-in type hierarchy. |
| src/data_profiling/model/describe.py | Updates typeset annotations and documentation. |
| src/data_profiling/expectations_report.py | Migrates expectation handlers and validates typeset availability. |
| pyproject.toml | Removes the visions dependency. |
| docs/reference/history.md | Updates project history and type-system attribution. |
| docs/getting-started/concepts.md | Documents built-in types, precedence, and tracing. |
| docs/features/sensitive_data.md | Shows explicit text typing for numeric-looking strings. |
| docs/features/metadata.md | Updates schema-inference guidance. |
Review effort: Balanced
| for relation in self.relations_from(node, inferential): | ||
| if relation.type in path: | ||
| continue | ||
| if relation.is_relation(series, state): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR removes the dependency on visions to reduce external maintenance overhead and avoid potential licensing compatibility issues.