Skip to content

fix: Respect progress_bar=False in internal column-profiling progress bar - #1891

Open
narodr wants to merge 1 commit into
Data-Centric-AI-Community:developfrom
narodr:narodr-fix-progress-bar-disable
Open

narodr wants to merge 1 commit into
Data-Centric-AI-Community:developfrom
narodr:narodr-fix-progress-bar-disable

Conversation

@narodr

@narodr narodr commented Nov 5, 2026 •

Copy link
Copy Markdown

Fixes #1890

The column-processing tqdm loop in pandas_get_series_descriptions ignored progress_bar=False. It now passes disable=not config.progress_bar. Adds a regression test checking stderr is empty with progress_bar=False.

Checklist:

  • black style (make lint): black, isort, pyupgrade, blacken-docs and tryceratops pass on the changed files. flake8 crashes under Python 3.13 and mypy only flags an unrelated file (utils/backend.py).
  • docs (make docs) - not applicable
  • tests (make test): the new test passes with the fix and fails without it. In the full unit and issues suite, the same 55 failures and 3 errors occur with and without this change (Python 3.13 DeprecationWarnings and Windows environment issues). Notebook tests were not run.
  • examples (make examples) - not applicable

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@narodr narodr changed the title Respect progress_bar=False in internal column-profiling progress bar fix: Respect progress_bar=False in internal column-profiling progress bar Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal column-profiling progress bar ignores progress_bar=False

1 participant