Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Passports #2237

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

WIP: Passports #2237

wants to merge 4 commits into from

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 26, 2024

Addresses

TODO

Summary

This is a rough first pass/proof of concept at trying to generate a compliant GA4GH passport implementation.

Things that we need to review for achieving compliance:

  • Request a ga4gh_passport_v1 scope for all passport requests
  • Encryption. The spec requires that: "Visas are signed JWTs encoded into strings using JWS Compact Serialization". This PR provides a decoded version for demonstration purposes
  • Implement something to associate the passport to a Sam user.
  • Complete the various claim type implementations

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong changed the title Gr passports WIP: Passports Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant