Skip to content

Conversation

typotter
Copy link
Contributor

@typotter typotter commented Jun 28, 2025

This replaces #3604

Motivation

We are allowing the SDK to proxy its configuration and as such, need to be able to set request headers.

Changes

  • add customHeaders to the provider init options
  • add overwriteHeaders option to suppress dd-application-id and dd-client-token from being included in the request

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@typotter typotter requested a review from a team as a code owner June 28, 2025 05:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.98%. Comparing base (e0c1a52) to head (31f1d58).

Files with missing lines Patch % Lines
packages/flagging/src/openfeature/provider.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           flagging-dev    #3660      +/-   ##
================================================
- Coverage         92.07%   91.98%   -0.10%     
================================================
  Files               326      326              
  Lines              8201     8206       +5     
  Branches           1856     1860       +4     
================================================
- Hits               7551     7548       -3     
- Misses              650      658       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@typotter typotter requested a review from leoromanovsky June 28, 2025 06:18
@typotter
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 30, 2025

View all feedbacks in Devflow UI.

2025-06-30 03:50:53 UTC ℹ️ Start processing command /merge


2025-06-30 03:50:57 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in flagging-dev is approximately 0s (p90).


2025-06-30 03:53:36 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for b3722e6:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@typotter typotter merged commit 1612fc6 into flagging-dev Jun 30, 2025
15 of 17 checks passed
@typotter typotter deleted the tp/sdk-protocol branch June 30, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants