Skip to content

Conversation

bcaudan
Copy link
Collaborator

@bcaudan bcaudan commented Sep 16, 2025

Motivation

Regression introduced by the migration of scripts to typescript.
Avoid to miss impactful size change by not having warnings added to the PR.

Changes

  • add unit tests on create message logic
  • remove number type checks

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.33% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad6ee2b | Docs | Was this helpful? Give us feedback!

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 159.69 KiB 159.69 KiB 0 B 0.00%
Rum Recorder 19.53 KiB 19.53 KiB 0 B 0.00%
Rum Profiler 5.18 KiB 5.18 KiB 0 B 0.00%
Logs 55.76 KiB 55.76 KiB 0 B 0.00%
Flagging N/A 931 B 931 B N/A%
Rum Slim 117.36 KiB 117.36 KiB 0 B 0.00%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.005 0.006 0.000
addaction 0.018 0.016 -0.002
addtiming 0.006 0.004 -0.003
adderror 0.020 0.017 -0.003
startstopsessionreplayrecording 0.001 0.001 -0.000
startview 0.005 0.004 -0.001
logmessage 0.024 0.017 -0.007
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 26.13 KiB 25.70 KiB -435 B
addaction 46.65 KiB 46.71 KiB 63 B
addtiming 24.01 KiB 24.97 KiB 981 B
adderror 50.51 KiB 50.52 KiB 5 B
startstopsessionreplayrecording 24.14 KiB 24.47 KiB 337 B
startview 424.39 KiB 429.13 KiB 4.74 KiB
logmessage 43.74 KiB 42.26 KiB -1514 B

🔗 RealWorld

@bcaudan bcaudan mentioned this pull request Sep 16, 2025
4 tasks
@bcaudan bcaudan marked this pull request as ready for review September 16, 2025 16:25
@bcaudan bcaudan requested a review from a team as a code owner September 16, 2025 16:25
@bcaudan bcaudan merged commit 777f42f into main Sep 17, 2025
21 checks passed
@bcaudan bcaudan deleted the bcaudan/fix-performance-script branch September 17, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants