-
Notifications
You must be signed in to change notification settings - Fork 162
🐛 [RUM-11850] Remove anonymous Id when consent is not granted #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f081a8 to
de468a8
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: b3cdd4a | Docs | Was this helpful? Give us feedback! |
ef99cc4 to
c18f1ea
Compare
BenoitZugmeyer
approved these changes
Oct 6, 2025
Comment on lines
21
to
27
| hasConsent: boolean = true | ||
| ): SessionState { | ||
| const expiredSessionState: SessionState = { | ||
| isExpired: EXPIRED, | ||
| } | ||
| if (configuration.trackAnonymousUser) { | ||
| if (previousSessionState?.anonymousId) { | ||
| expiredSessionState.anonymousId = previousSessionState?.anonymousId | ||
| } else { | ||
| expiredSessionState.anonymousId = generateUUID() | ||
| } | ||
| if (hasConsent && configuration.trackAnonymousUser && previousSessionState?.anonymousId) { | ||
| expiredSessionState.anonymousId = previousSessionState?.anonymousId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: remove the hasConsent parameter as it's not used anymore
915ea40 to
8f278ab
Compare
thomas-lebeau
approved these changes
Oct 6, 2025
fd1cb60 to
b3cdd4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to remove the anonymous id from the cookie when consent is not granted.
Changes
startSessionhasConsentboolean when the consent isnot-grantedand remove the anonymous Id accordinglyTest instructions
anonymousIdshould not present in cookie anymoreChecklist