Skip to content

Conversation

mormubis
Copy link
Contributor

@mormubis mormubis commented Oct 7, 2025

Motivation

The latest changes in Logs enable the SDK to function in Node environments. This side effect was unintended.

Changes

The PR introduces a condition that blocks SDK initialization in Node environments.

Test instructions

Compatibility test passed.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 7, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 71.43%
Total Coverage: 92.61% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5c41345 | Docs | Was this helpful? Give us feedback!

@mormubis mormubis changed the title fix: block logs in node 🐛 Block Logs initialization on Node environments Oct 7, 2025
Copy link

cit-pr-commenter bot commented Oct 9, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.82 KiB 162.86 KiB +40 B +0.02%
Rum Recorder 19.78 KiB 19.78 KiB 0 B 0.00%
Rum Profiler 4.89 KiB 4.89 KiB 0 B 0.00%
Logs 56.50 KiB 56.55 KiB +52 B +0.09%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 119.78 KiB 119.81 KiB +29 B +0.02%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0041 0.006 +46.34%
RUM - add action 0.0153 0.0149 -2.61%
RUM - add error 0.0134 0.013 -2.99%
RUM - add timing 0.0031 0.0033 +6.45%
RUM - start view 0.004 0.004 0.00%
RUM - start/stop session replay recording 0.0007 0.0008 +14.29%
Logs - log message 0.0142 0.0162 +14.08%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.83 KiB 25.35 KiB -494 B
RUM - add action 46.57 KiB 44.87 KiB -1.70 KiB
RUM - add timing 24.55 KiB 25.04 KiB +498 B
RUM - add error 51.08 KiB 113.47 KiB +62.39 KiB
RUM - start/stop session replay recording 23.54 KiB 23.98 KiB +442 B
RUM - start view 420.30 KiB 489.92 KiB +69.61 KiB
Logs - log message 43.18 KiB 41.45 KiB -1.72 KiB

🔗 RealWorld

@mormubis mormubis marked this pull request as ready for review October 9, 2025 10:32
@mormubis mormubis requested a review from a team as a code owner October 9, 2025 10:32
@@ -1,3 +1,5 @@
/* eslint-disable */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 27 is reporting @typescript-eslint/no-unsafe-call even when I disable the line 😕

@mormubis mormubis changed the title 🐛 Block Logs initialization on Node environments 🐛 [RUM-11848] Block Logs initialization on Node environments Oct 9, 2025
@mormubis
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 16, 2025

View all feedbacks in Devflow UI.

2025-10-16 07:44:45 UTC ℹ️ Start processing command /merge


2025-10-16 07:44:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 35m (p90).


2025-10-16 07:48:48 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for beac9bf:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@mormubis
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 16, 2025

View all feedbacks in Devflow UI.

2025-10-16 09:11:54 UTC ℹ️ Start processing command /merge


2025-10-16 09:11:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 35m (p90).


2025-10-16 09:59:37 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants