-
Notifications
You must be signed in to change notification settings - Fork 161
🐛 Add mask-unless-allowlisted privacy level support for standard attr #3907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ebfde81
to
1ad9e51
Compare
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory Performance
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 06574d5 | Docs | Was this helpful? Give us feedback! |
0913df3
to
168b5d1
Compare
168b5d1
to
71674a9
Compare
/to-staging |
View all feedbacks in Devflow UI.
Commit 71674a9ec7 will soon be integrated into staging-42.
Commit 71674a9ec7 has been merged into staging-42 in merge commit 58ffb86f27. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
… into staging-42 Integrated commit sha: 71674a9 Co-authored-by: cy-moi <[email protected]>
…utes action names
9932c44
to
06574d5
Compare
Motivation
Following up on the new
mask-unless-allowlisted
behavior, in which case we mask with allowlists whenshouldMaskNode
is true andenablePrivacyForActionName
turned on. However, it seems like we did not cover standard attributes.Changes
Make masking for standard attributes the same as the textual content.
Test instructions
Should pass CI
Note: This PR has a dependency on https://github.com/DataDog/web-ui/pull/237816 when testing on staging.
Checklist