Skip to content

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Oct 10, 2025

Motivation

Following up on the new mask-unless-allowlisted behavior, in which case we mask with allowlists when shouldMaskNode is true and enablePrivacyForActionName turned on. However, it seems like we did not cover standard attributes.

Changes

Make masking for standard attributes the same as the textual content.

Test instructions

Should pass CI
Note: This PR has a dependency on https://github.com/DataDog/web-ui/pull/237816 when testing on staging.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@cy-moi cy-moi force-pushed the congyao/fix-mask-unless-allowlist-for-standard-attr branch from ebfde81 to 1ad9e51 Compare October 10, 2025 15:29
Copy link

cit-pr-commenter bot commented Oct 10, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.08 KiB 162.25 KiB +177 B +0.11%
Rum Recorder 19.78 KiB 19.78 KiB 0 B 0.00%
Rum Profiler 4.89 KiB 4.89 KiB 0 B 0.00%
Logs 55.77 KiB 55.77 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 119.06 KiB 119.28 KiB +230 B +0.19%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.46 KiB 25.59 KiB +134 B
RUM - add action 45.97 KiB 45.83 KiB -142 B
RUM - add timing 24.34 KiB 25.11 KiB +792 B
RUM - add error 51.44 KiB 49.49 KiB -1.95 KiB
RUM - start/stop session replay recording 24.89 KiB 24.04 KiB -872 B
RUM - start view 422.83 KiB 428.33 KiB +5.50 KiB
Logs - log message 43.14 KiB 42.19 KiB -974 B

🔗 RealWorld

Copy link

datadog-official bot commented Oct 10, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.68% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 06574d5 | Docs | Was this helpful? Give us feedback!

@cy-moi cy-moi force-pushed the congyao/fix-mask-unless-allowlist-for-standard-attr branch 2 times, most recently from 0913df3 to 168b5d1 Compare October 13, 2025 10:59
@cy-moi cy-moi changed the title Add mask-unless-allowlisted privacy level support for standard attr 🐛 Add mask-unless-allowlisted privacy level support for standard attr Oct 13, 2025
@cy-moi cy-moi force-pushed the congyao/fix-mask-unless-allowlist-for-standard-attr branch from 168b5d1 to 71674a9 Compare October 13, 2025 11:00
@cy-moi
Copy link
Contributor Author

cy-moi commented Oct 13, 2025

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 13, 2025

View all feedbacks in Devflow UI.

2025-10-13 11:18:14 UTC ℹ️ Start processing command /to-staging


2025-10-13 11:18:20 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 0s (p90)

Commit 71674a9ec7 will soon be integrated into staging-42.


2025-10-13 11:29:20 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit 71674a9ec7 has been merged into staging-42 in merge commit 58ffb86f27.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-42

dd-mergequeue bot added a commit that referenced this pull request Oct 13, 2025
… into staging-42

Integrated commit sha: 71674a9

Co-authored-by: cy-moi <[email protected]>
@cy-moi cy-moi force-pushed the congyao/fix-mask-unless-allowlist-for-standard-attr branch from 9932c44 to 06574d5 Compare October 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant