Skip to content

Commit

Permalink
Update release-1.29-dd to 1.29.6 (#1)
Browse files Browse the repository at this point in the history
* Handle error while registering/deregistering target during load balancer update

* Release v1.29.6

---------

Co-authored-by: Jay Deokar <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
  • Loading branch information
3 people authored Oct 4, 2024
1 parent 56fd1f8 commit aef3c52
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pkg/providers/v1/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -4492,7 +4492,8 @@ func (c *Cloud) UpdateLoadBalancer(ctx context.Context, clusterName string, serv

err = c.ensureLoadBalancerInstances(aws.StringValue(lb.LoadBalancerName), lb.Instances, instances)
if err != nil {
return nil
klog.Warningf("Error registering/deregistering instances with the load balancer: %q", err)
return err
}

err = c.updateInstanceSecurityGroupsForLoadBalancer(lb, instances, service.Annotations)
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.29.5
1.29.6

0 comments on commit aef3c52

Please sign in to comment.