[windows] Reduce size of Windows images #47
+208
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lebot
approved these changes
Jun 10, 2020
windows/scripts/postsetup.ps1
Outdated
| setx RIDK ((Get-Command ridk).Path) | ||
|
|
||
| # (32-bit only) Install 32-bit C/C++ compilation toolchain | ||
| if ($Env:TARGET_ARCH -eq 'x86') { ridk enable; bash -c "pacman -S --needed --noconfirm mingw-w64-i686-binutils mingw-w64-i686-crt-git mingw-w64-i686-gcc mingw-w64-i686-gcc-libs mingw-w64-i686-headers-git mingw-w64-i686-libmangle-git mingw-w64-i686-libwinpthread-git mingw-w64-i686-make mingw-w64-i686-pkg-config mingw-w64-i686-tools-git mingw-w64-i686-winpthreads-git" } |
There was a problem hiding this comment.
Nit: I think it could help legibility to format long lines over multiple lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves chocolatey setup commands into a single powershell script to drastically reduce the number of layers of the Windows images, and thus reduce the total size of the image.
Bases 1909 images off a different image that already has .NET 3.5, since 1909 has .NET 4.8 by default. This allows us to remove the .NET 3.5 setup step, which takes a lot of space.
This brings the (uncompressed) images to:
1809_x64: 17.2GB -> 16.1GB
1909_x64: 20.9GB -> 16.7GB
1809_x86: 17.4GB -> 16.5GB
1909_x86: 20.9GB -> 16.9GB
Motivation
Reduce size of images.