-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart build in buildimages #578
Draft
chouetz
wants to merge
11
commits into
main
Choose a base branch
from
nschweitzer/dynamic_build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
force-pushed
the
nschweitzer/dynamic_build
branch
from
October 24, 2024 14:22
9903180
to
a58e4e7
Compare
chouetz
force-pushed
the
nschweitzer/dynamic_build
branch
from
October 24, 2024 14:26
a58e4e7
to
4351df8
Compare
chouetz
force-pushed
the
nschweitzer/dynamic_build
branch
from
October 24, 2024 15:49
e17c71c
to
9f056f1
Compare
- Fix the task name typo - Aligned the variable names to the IMAGE name used in gitlab configuration - Add tests for the parts of the generate task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new
rule:changes:path
on all the build jobs of the gitlab pipeline, to build only the required images, based on modified content.As a consequence, I also modified the
trigger_test
to adapt with this smart build:generate_tests
job will fill-in the newly createdtrigger_template.yml
with only the required imagestrigger_datadog_agent_tests
job runs the generated file as a child pipeline.I did several tests to validate this change [WIP]:
datadog-agent
pipeline with the created images