Support Datadog feature flags #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
10 times, most recently
from
3d4fc3a to
e09b016
Compare
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
from
e09b016 to
826b998
Compare
ofek
requested changes
Oct 14, 2025
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
6 times, most recently
from
a9c82ad to
3315e9c
Compare
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
from
3315e9c to
d0ef55f
Compare
ofek
reviewed
Oct 15, 2025
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
3 times, most recently
from
6b8fd15 to
536a5fc
Compare
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
from
536a5fc to
d7a0c79
Compare
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
from
2165e46 to
e0fc87d
Compare
ofek
reviewed
Oct 17, 2025
| VERBOSE = "DDA_VERBOSE" | ||
| NO_DYNAMIC_DEPS = "DDA_NO_DYNAMIC_DEPS" | ||
| TELEMETRY_API_KEY = "DDA_TELEMETRY_API_KEY" | ||
| FEATURE_FLAGS_CLIENT_TOKEN = "DDA_FEATURE_FLAGS_CLIENT_TOKEN" # noqa: S105 This is not a hardcoded secret but the linter complains on it |
There was a problem hiding this comment.
Suggested change
| FEATURE_FLAGS_CLIENT_TOKEN = "DDA_FEATURE_FLAGS_CLIENT_TOKEN" # noqa: S105 This is not a hardcoded secret but the linter complains on it | |
| FEATURE_FLAGS_CLIENT_TOKEN = "DDA_FEATURE_FLAGS_CLIENT_TOKEN" # noqa: S105 |
| import json | ||
| from typing import TYPE_CHECKING, Any | ||
|
|
||
| from httpx import HTTPError |
There was a problem hiding this comment.
This should be lazily imported where it's required.
Comment on lines
+56
to
+58
| } | ||
|
|
||
| headers["dd-application-id"] = self.__app_id |
There was a problem hiding this comment.
Suggested change
| } | |
| headers["dd-application-id"] = self.__app_id | |
| "dd-application-id": self.__app_id, | |
| } |
| self.__cache: dict[tuple[str, str, tuple[tuple[str, str], ...]], Any] = {} | ||
|
|
||
| @cached_property | ||
| def __client_token(self) -> str | None: |
There was a problem hiding this comment.
I think this is only used by the client and it feels odd to instantiate the client with potentially no token, requiring the client to check how it was constructed. Can we change this property to create and return a client or None if we can't get a token?
| if isinstance(value, str): | ||
| stringified_attributes[key] = value | ||
| else: | ||
| stringified_attributes[key] = json.dumps(value) |
There was a problem hiding this comment.
I don't think this is desirable. Can we just rely on the backend rejecting bad data?
>>> import json
>>> json.dumps(0)
'0'
>>> json.dumps(None)
'null'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Feature Flag support inside
ddacommands.Mostly solve the problems described in: https://datadoghq.atlassian.net/wiki/spaces/~7120201870126a495245b69e47156354de0ad9/pages/5569413152/Feature+Flags+dda?atlOrigin=eyJpIjoiZWI5Y2NjNTRhMDViNDc3NmFkYWNlNGVmOGExMjkzY2QiLCJwIjoiYyJ9
In that PR feature flags are only supported when running command locally.
A client token is required and will be fetched using the same mechanism as for the telemetry API key.
The feature flag can be used easily inside the application code by calling
app.features.enabled("flag", "default_value", extra_context)The extra context is not needed, by default the context is populated here and contains info about whether this is a CI run, and the username if it exists