-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Type for extracting trace context from various event types [SVLS-3934]. #20363
Conversation
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 882284d2-9663-4d13-ade1-af357bbcebc1 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
e42c67a
to
8bb8198
Compare
FYI, I have incorporated this PR #19888 |
9fb05e9
to
04c377b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that this requires a replace statement. Since the required commit is not yet released, it must instead be pulled from github.
04c377b
to
cb068c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…es [SVLS-3934]. (#20363) * Type for extracting trace context from various event types. * Add copyright headers to new files. * Fix linting errors. * Gofmt with a -s. * Update licenses. * Add package level comment. * ExtractFromLayer returns nil TraceContext if not trace and parent id. * Update go.mod with required dd-trace-go version. Note that this requires a replace statement. Since the required commit is not yet released, it must instead be pulled from github. * Fix the raw-message-delivery case. From #19888
What does this PR do?
Creates a new
Extractor
type which will allow us to extract trace context from various event types. The type defers extraction to dd-trace-go so as to offer out of the box support for W3C trace context without us having to implement it here.Motivation
We should be using dd-trace-go wherever possible for trace context extraction.
Additional Notes
The passing of tests in this PR are reliant on DataDog/dd-trace-go#2291, which after merge will need to be pinned in the go.mod file. I will do that work before setting this PR as ready for review.
That pull request is now merged but not yet released. In order to pull in the updated dd-trace-go, a replace statement is added to go.mod.
Possible Drawbacks / Trade-offs
Requiring dd-trace-go does not increase the binary size of the Extension. See https://github.com/DataDog/datadog-agent/actions/runs/6697892429/job/18198738509?pr=20363#step:9:2
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.