-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] Replace 64 bits trace ID by 128 bits for ebpf and ebpfless #27059
Conversation
Go Package Import DifferencesBaseline: 94c9e78
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=40650360 --os-family=ubuntu Note: This applies to commit 988c63f |
Regression DetectorRegression Detector ResultsRun ID: 1477c9d4-7991-4c2b-ad93-ebd938d55558 Metrics dashboard Target profiles Baseline: 94c9e78 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +2.34 | [-0.22, +4.90] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.12 | [+0.23, +2.02] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.96 | [-11.99, +13.91] | Logs |
➖ | file_tree | memory utilization | +0.16 | [+0.09, +0.22] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.21 | [-1.02, +0.60] | Logs |
➖ | idle | memory utilization | -0.76 | [-0.80, -0.73] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.86 | [-6.67, +2.95] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
da60204
to
8b39ab6
Compare
6eb2049
to
7a023ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing for docs to review.
7a023ca
to
c572292
Compare
c572292
to
4583abf
Compare
b601217
to
262ee75
Compare
262ee75
to
988c63f
Compare
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
/remove |
🚂 Devflow: |
This merge request was unqueued If you need support, contact us on Slack #devflow! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
It updates trace IDs to 128bits (as it's the new standard for the trace agent).
I've updated:
Also now, both span and trace ID are serialized to the backend as string (instead of uint64).
NB: span can be sent as decimal string but trace HAVE to be sent as LOWERCASE hexa, otherwise it wont work.
The java tracer has been updated too: DataDog/dd-trace-java#7259
Spans and traces maked as deprecated in activity dump proto in agent payload: DataDog/agent-payload#323
Motivation
Be compliant with the new dd tracer.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Tests are passing with ebpf and ebpfless. You could play with syscalltester and with a traced java app