Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in generator template #2826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in generator template #2826

wants to merge 1 commit into from

Conversation

Drarig29
Copy link

@Drarig29 Drarig29 commented Dec 9, 2024 •
edited
Loading

What does this PR do?

This PR fixes a typo in the Go client generator template.

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.

  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@Drarig29 Drarig29 marked this pull request as ready for review December 9, 2024 11:48
@Drarig29 Drarig29 requested a review from a team as a code owner December 9, 2024 11:48
@Drarig29 Drarig29 added the changelog/no-changelog Changes don't appear in changelog label Dec 9, 2024
@Drarig29
Copy link
Author

@HantingZhang2 note that I don't know why the CI has some "expected" jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HantingZhang2 HantingZhang2 HantingZhang2 approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog Changes don't appear in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drarig29 @HantingZhang2