Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1153] APM e2e test #1549

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CECO-1153] APM e2e test #1549

wants to merge 3 commits into from

Conversation

tbavelier
Copy link
Member

What does this PR do?

Introduces an APM e2e test in two parts:

  • Ensuring traces are received locally (at the Agent level) for all 3 services, using all 3 methods (TCP on hostPort, Agent service and UDP using socket)
  • Ensuring traces are sent to the API

Motivation

What inspired you to submit this pull request?

Additional Notes

Some additional nits:

  • WithDevMode should be removed in main branch, it should only be used for dev
  • Some deployments used by tests should be cleaned up after said test
  • Timeout for some tests could probably be reduced

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added this to the v1.12.0 milestone Dec 5, 2024
@tbavelier tbavelier requested a review from a team as a code owner December 5, 2024 09:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.66%. Comparing base (993280d) to head (a64b417).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1549   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         226      226           
  Lines       20363    20363           
=======================================
  Hits         9909     9909           
  Misses       9937     9937           
  Partials      517      517           
Flag Coverage Δ
unittests 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993280d...a64b417. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants