Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GPU monitoring #1601

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gjulianm
Copy link
Collaborator

@gjulianm gjulianm commented Jan 3, 2025

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@gjulianm gjulianm self-assigned this Jan 3, 2025
@gjulianm gjulianm added the enhancement New feature or request label Jan 3, 2025
@gjulianm gjulianm added this to the v1.12.0 milestone Jan 3, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 5.76923% with 98 lines in your changes missing coverage. Please review.

Project coverage is 48.72%. Comparing base (efaa4e9) to head (6777208).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nal/controller/datadogagent/feature/gpu/feature.go 0.00% 98 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
- Coverage   48.94%   48.72%   -0.22%     
==========================================
  Files         227      228       +1     
  Lines       20635    20739     +104     
==========================================
+ Hits        10100    10106       +6     
- Misses      10010    10108      +98     
  Partials      525      525              
Flag Coverage Δ
unittests 48.72% <5.76%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/datadogagent_default.go 91.24% <100.00%> (+0.14%) ⬆️
api/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)
...nal/controller/datadogagent/feature/gpu/feature.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efaa4e9...6777208. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants