Add PodResources mount to agent #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulianm
force-pushed
the
guillermo.julian/pod-resources-socket
branch
from
9d61da1 to
b9e0baf
Compare
estherk15
approved these changes
Feb 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
+ Coverage 49.17% 49.25% +0.08%
==========================================
Files 218 218
Lines 21033 21069 +36
==========================================
+ Hits 10342 10378 +36
Misses 10150 10150
Partials 541 541
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
celenechang
reviewed
Feb 4, 2025
celenechang
approved these changes
Feb 4, 2025
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the mount for the PodResources socket.
Motivation
The pod resources API is necessary for correctly assigning pods to GPU devices in GPU monitoring.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Tested locally by deploying the operator in a cluster, deploying an agent with default settings and ensuring that:
/var/lib/kubelet/pod-resources/kubelet.sockDD_KUBERNETES_KUBELET_POD_RESOURCES_SOCKETis correctly set to/var/lib/kubelet/pod-resources/kubelet.sock.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel