Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: added cgroup mount to gpu feature #1652

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

val06
Copy link
Contributor

@val06 val06 commented Feb 4, 2025

What does this PR do?

add a missing cgroup mount to gpu monitoring feature of system-probe

Motivation

gpu-probe is using cgroups mount to adjust device cgroups

Additional Notes

Jira ticket

similar to this PR that adds the mount for the service-discovery feature and same mount already added for NPM/USM

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

Agent: v7.64.x for the GPU monitoring feature.
Cluster Agent: N/A

Describe your test plan

  1. Deploy the operator in a cluster
  2. Deploy the agent resource with feature.gpu.enabled: yes and service_discovery, usm and npm are disabled.
  3. Check that deployed agent has a cgroup mount in the system-probe container

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@val06 val06 added the enhancement New feature or request label Feb 4, 2025
@val06 val06 requested a review from a team as a code owner February 4, 2025 17:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.18%. Comparing base (7a86900) to head (08c4adb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1652   +/-   ##
=======================================
  Coverage   49.17%   49.18%           
=======================================
  Files         218      218           
  Lines       21033    21037    +4     
=======================================
+ Hits        10342    10346    +4     
  Misses      10150    10150           
  Partials      541      541           
Flag Coverage Δ
unittests 49.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nal/controller/datadogagent/feature/gpu/feature.go 90.47% <100.00%> (+0.37%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a86900...08c4adb. Read the comment docs.

@val06 val06 added this to the v1.12.0 milestone Feb 4, 2025
@swang392 swang392 modified the milestones: v1.12.0, v1.13.0 Feb 4, 2025
@val06
Copy link
Contributor Author

val06 commented Feb 5, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 09:16:53 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 17m.


2025-02-05 09:33:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3b49a53 into main Feb 5, 2025
26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the valeri.pliskin/gpufeature-cgroups-mount branch February 5, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants