Repository navigation
Conversation
nina9753
force-pushed
the
nina.rei/SVLS-9784/runtime-version
branch
from
November 9, 2026 17:29
e26e14f to
fa48172
Compare
nina9753
marked this pull request as ready for review
November 9, 2026 17:33
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nina9753
force-pushed
the
nina.rei/SVLS-9784/runtime-version
branch
from
November 11, 2026 18:54
18374fb to
70aa7d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward a single best-effort language-engine hint to the Compat child through
DD_SERVERLESS_COMPAT_RUNTIME(language plus version). This addresses Duncan's review feedback without overwriting platform-owned version variables.FUNCTIONS_WORKER_RUNTIME_VERSIONand other platform settings.Binary dependency and release ordering
The shared reader change is serverless-components #202. It prefers the optional combined hint and falls back to existing platform detection if missing, empty, or unknown.
Release and bundle a binary containing that reader before relying on this hint. Published v0.31.0 does not support the new variable. This PR does not claim a new binary release or change its artifact pin.
Metadata stays opt-in with
DD_SERVERLESS_COMPAT_METADATA_ENABLED=true; customers do not need to set the new hint.Validation
Updated .NET tests have not run locally because the SDK is unavailable. Windows/Linux CI validation is still required.
git diff --checkpassed. No live canary has been rerun for this revised hint contract; earlier canary results for the old platform-variable approach do not validate this revision.Related work: SVLS-9784.