RUM-7999: Prevent sampled out spans from sending #2549
+145
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
maciejburda
force-pushed
the
maciey/RUM-7999/sampled-out-spans-sending
branch
from
ca096bc to
db001b7
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ncreated
reviewed
Nov 10, 2025
ncreated
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This code aligns the implementation on iOS with expectations and lays down foundation for SDK level traces metrics in the future.
Additionally it expands root span creation API with customisable sampling rate that will override global configuration in the context of the single Trace.
How?
Key change is on Span
finish()function that now doesn't forward the span for writing whenisKept == false.Review checklist
make api-surface)