-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R&D Week][Profiler] Gleocadie/walltime profiler optimization execution hijack #6418
base: master
Are you sure you want to change the base?
[R&D Week][Profiler] Gleocadie/walltime profiler optimization execution hijack #6418
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 461163 Passed, 2789 Skipped, 17h 54m 21.64s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6418) - mean (68ms) : 65, 71
. : milestone, 68,
master - mean (68ms) : 65, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6418) - mean (977ms) : 957, 997
. : milestone, 977,
master - mean (977ms) : 953, 1000
. : milestone, 977,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6418) - mean (107ms) : 105, 110
. : milestone, 107,
master - mean (107ms) : 105, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6418) - mean (675ms) : 661, 689
. : milestone, 675,
master - mean (677ms) : 660, 694
. : milestone, 677,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6418) - mean (91ms) : 88, 93
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6418) - mean (633ms) : 616, 649
. : milestone, 633,
master - mean (633ms) : 615, 650
. : milestone, 633,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6418) - mean (193ms) : 188, 199
. : milestone, 193,
master - mean (194ms) : 190, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6418) - mean (1,098ms) : 1075, 1121
. : milestone, 1098,
master - mean (1,098ms) : 1071, 1125
. : milestone, 1098,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6418) - mean (277ms) : 273, 282
. : milestone, 277,
master - mean (277ms) : 271, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6418) - mean (868ms) : 842, 895
. : milestone, 868,
master - mean (873ms) : 838, 908
. : milestone, 873,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6418) - mean (267ms) : 261, 272
. : milestone, 267,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6418) - mean (852ms) : 818, 887
. : milestone, 852,
master - mean (853ms) : 820, 885
. : milestone, 853,
|
Benchmarks Report for tracer 🐌Benchmarks for #6418 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.136 | 398.33 | 452.66 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 398ns | 0.273ns | 1.06ns | 0.00802 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 618ns | 0.659ns | 2.55ns | 0.0077 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 674ns | 2.01ns | 7.78ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 492ns | 0.46ns | 1.78ns | 0.00965 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 751ns | 0.711ns | 2.75ns | 0.00947 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 823ns | 3.16ns | 11.8ns | 0.105 | 0 | 0 | 658 B |
#6418 | StartFinishSpan |
net6.0 | 452ns | 0.283ns | 1.1ns | 0.00796 | 0 | 0 | 576 B |
#6418 | StartFinishSpan |
netcoreapp3.1 | 620ns | 0.54ns | 1.95ns | 0.00772 | 0 | 0 | 576 B |
#6418 | StartFinishSpan |
net472 | 708ns | 0.502ns | 1.94ns | 0.0915 | 0 | 0 | 578 B |
#6418 | StartFinishScope |
net6.0 | 494ns | 0.447ns | 1.73ns | 0.00968 | 0 | 0 | 696 B |
#6418 | StartFinishScope |
netcoreapp3.1 | 701ns | 0.452ns | 1.69ns | 0.00959 | 0 | 0 | 696 B |
#6418 | StartFinishScope |
net472 | 827ns | 0.705ns | 2.73ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6418
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.129
643.29
726.35
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.129 | 643.29 | 726.35 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 643ns | 0.442ns | 1.65ns | 0.00981 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 923ns | 0.497ns | 1.86ns | 0.00924 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.14μs | 0.524ns | 2.03ns | 0.104 | 0 | 0 | 658 B |
#6418 | RunOnMethodBegin |
net6.0 | 726ns | 0.965ns | 3.74ns | 0.00979 | 0 | 0 | 696 B |
#6418 | RunOnMethodBegin |
netcoreapp3.1 | 908ns | 0.504ns | 1.89ns | 0.0091 | 0 | 0 | 696 B |
#6418 | RunOnMethodBegin |
net472 | 1.1μs | 0.456ns | 1.77ns | 0.105 | 0 | 0 | 658 B |
8169d91
to
d8b6435
Compare
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6418) (11.198M) : 0, 11197739
master (11.207M) : 0, 11207401
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6418) (7.235M) : 0, 7235059
master (7.306M) : 0, 7305881
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.547M) : 0, 7547108
section Manual
master (10.807M) : 0, 10807085
section Manual + Automatic
This PR (6418) (6.696M) : 0, 6696010
master (6.654M) : 0, 6654300
section DD_TRACE_ENABLED=0
master (10.240M) : 0, 10239959
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6418) (9.600M) : 0, 9600043
master (9.559M) : 0, 9558927
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6418) (6.342M) : 0, 6342363
master (6.276M) : 0, 6276496
section Trace stats
master (6.702M) : 0, 6702308
section Manual
master (9.582M) : 0, 9582063
section Manual + Automatic
This PR (6418) (5.843M) : 0, 5842500
master (5.938M) : 0, 5937696
section DD_TRACE_ENABLED=0
master (9.073M) : 0, 9072831
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6418) (9.695M) : 0, 9695128
master (10.036M) : 0, 10035894
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6418) (6.172M) : crit ,0, 6171576
master (6.535M) : 0, 6535216
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.175M) : 0, 7175343
section Manual
master (9.942M) : 0, 9942221
section Manual + Automatic
This PR (6418) (5.675M) : crit ,0, 5675221
master (6.147M) : 0, 6147492
section DD_TRACE_ENABLED=0
master (9.295M) : 0, 9295444
|
d2b53d8
to
fc8f0a6
Compare
fc8f0a6
to
a86a826
Compare
Summary of changes
Reason for change
Implementation details
Test coverage
Other details