Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracing] Update telemetry metrics for OpenTelemetry integration #6454

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[Tracing] Update telemetry metrics for OpenTelemetry integration #6454

wants to merge 3 commits into from

Conversation

zacharycmontoya
Copy link
Collaborator

@zacharycmontoya zacharycmontoya commented Dec 17, 2024 •
edited
Loading

Summary of changes

For the OpenTelemetry integration, update the tag generated for the span_created telemetry metric from integration_name:opentelemetry to integration_name:otel to align with other tracing libraries

Reason for change

Other tracing libraries generate span metrics using integration_name:otel.library or integration_name:otel to distinguish between OpenTelemetry Instrumentation Library usage or OpenTelemetry Custom Instrumentation usage. We cannot distinguish between the two, so we can simply use integration_name:otel

Implementation details

Update the static tag from integration_name:opentelemetry to integration_name:otel

Test coverage

This PR adds a test to assert the value of the integration_name tag attached to the span_creatted telemetry metric on all of our tracing integration tests. This was then used to test the updated tag value.

Other details

N/A

@github-actions github-actions bot added the area:tests unit tests, integration tests label Dec 17, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 17, 2024 •
edited
Loading

Datadog Report

Branch report: zach.montoya/otel-custom-instr-telemetry
Commit report: 6232fd9
Test service: dd-trace-dotnet

❌ 14 Failed (0 Known Flaky), 222651 Passed, 1917 Skipped, 17h 11m 40.74s Total Time

❌ Failed Tests (14)

This report shows up to 5 failed tests.

  • AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

    Expand for error 
     Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

  • AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

    Expand for error 
     Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

  • AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

    Expand for error 
     Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

  • AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

    Expand for error 
     Expected var spansCreated = spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

  • AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

    Expand for error 
     Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

@andrewlock
Copy link
Member

andrewlock commented Dec 17, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (977ms)  : 955, 998
     .   : milestone, 977,
    master - mean (975ms)  : 958, 992
     .   : milestone, 975,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (676ms)  : 660, 693
     .   : milestone, 676,
    master - mean (678ms)  : 663, 693
     .   : milestone, 678,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (632ms)  : 618, 646
     .   : milestone, 632,
    master - mean (636ms)  : 621, 650
     .   : milestone, 636,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (194ms)  : 191, 197
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (1,097ms)  : 1072, 1123
     .   : milestone, 1097,
    master - mean (1,101ms)  : 1069, 1133
     .   : milestone, 1101,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (279ms)  : 274, 285
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (874ms)  : 852, 897
     .   : milestone, 874,
    master - mean (875ms)  : 843, 907
     .   : milestone, 875,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (267ms)  : 262, 271
     .   : milestone, 267,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (848ms)  : 813, 883
     .   : milestone, 848,
    master - mean (852ms)  : 826, 879
     .   : milestone, 852,
Loading

@andrewlock
Copy link
Member

andrewlock commented Dec 18, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6454 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.122
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.09μs 45.5ns 322ns 0.0161 0.00402 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.2μs 51.8ns 254ns 0.0206 0.0103 0 5.8 KB
master StartStopWithChild net472 16.4μs 42.4ns 164ns 1.03 0.29 0.0966 6.21 KB
#6454 StartStopWithChild net6.0 8.09μs 42.6ns 217ns 0.0121 0.00403 0 5.6 KB
#6454 StartStopWithChild netcoreapp3.1 10.3μs 54.2ns 260ns 0.0155 0.00517 0 5.8 KB
#6454 StartStopWithChild net472 16.6μs 52.8ns 204ns 1.05 0.321 0.0988 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 482μs 258ns 998ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 390ns 1.51μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 852μs 534ns 2.07μs 0.422 0 0 3.3 KB
#6454 WriteAndFlushEnrichedTraces net6.0 499μs 256ns 993ns 0 0 0 2.7 KB
#6454 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 464ns 1.8μs 0 0 0 2.7 KB
#6454 WriteAndFlushEnrichedTraces net472 857μs 930ns 3.6μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 156μs 910ns 8.03μs 0.147 0 0 14.49 KB
master SendRequest netcoreapp3.1 169μs 982ns 9.16μs 0.165 0 0 17.27 KB
master SendRequest net472 0.00116ns 0.000747ns 0.00279ns 0 0 0 0 b
#6454 SendRequest net6.0 159μs 1.58μs 15.6μs 0.146 0 0 14.47 KB
#6454 SendRequest netcoreapp3.1 175μs 1.02μs 9.18μs 0.156 0 0 17.27 KB
#6454 SendRequest net472 0.00671ns 0.00178ns 0.00691ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6454

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.69 KB 41.4 KB -288 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 574μs 3.06μs 15.6μs 0.571 0 0 41.69 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.73μs 23.6μs 0.34 0 0 41.83 KB
master WriteAndFlushEnrichedTraces net472 836μs 4.21μs 18.4μs 8.33 2.5 0.417 53.26 KB
#6454 WriteAndFlushEnrichedTraces net6.0 547μs 2.66μs 14.3μs 0.563 0 0 41.4 KB
#6454 WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.36μs 14.7μs 0.338 0 0 41.77 KB
#6454 WriteAndFlushEnrichedTraces net472 862μs 4.06μs 15.2μs 8.19 2.59 0.431 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 0.978ns 3.79ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.75μs 1.51ns 5.84ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 2.57ns 9.94ns 0.157 0.00105 0 987 B
#6454 ExecuteNonQuery net6.0 1.32μs 0.927ns 3.59ns 0.0139 0 0 1.02 KB
#6454 ExecuteNonQuery netcoreapp3.1 1.81μs 3.3ns 12.8ns 0.0135 0 0 1.02 KB
#6454 ExecuteNonQuery net472 2.04μs 1.85ns 6.92ns 0.156 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 0.621ns 2.32ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.6μs 0.803ns 3.11ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.52μs 2.71ns 10.5ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.37μs 1.17ns 4.54ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 0.642ns 2.49ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 0.975ns 3.65ns 0.166 0 0 1.05 KB
#6454 CallElasticsearch net6.0 1.29μs 0.651ns 2.44ns 0.0135 0 0 976 B
#6454 CallElasticsearch netcoreapp3.1 1.57μs 0.817ns 3.06ns 0.0134 0 0 976 B
#6454 CallElasticsearch net472 2.48μs 1.71ns 6.41ns 0.157 0 0 995 B
#6454 CallElasticsearchAsync net6.0 1.36μs 0.435ns 1.63ns 0.013 0 0 952 B
#6454 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.8ns 2.99ns 0.0137 0 0 1.02 KB
#6454 CallElasticsearchAsync net472 2.7μs 2.58ns 9.99ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.813ns 3.04ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.71μs 0.785ns 2.94ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.84μs 1.2ns 4.67ns 0.145 0 0 915 B
#6454 ExecuteAsync net6.0 1.37μs 0.455ns 1.7ns 0.0131 0 0 952 B
#6454 ExecuteAsync netcoreapp3.1 1.6μs 0.705ns 2.64ns 0.013 0 0 952 B
#6454 ExecuteAsync net472 1.82μs 4.49ns 17.4ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.31μs 1.85ns 6.68ns 0.0323 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.21μs 1.84ns 7.12ns 0.039 0 0 2.85 KB
master SendAsync net472 7.38μs 2.5ns 9.69ns 0.495 0 0 3.12 KB
#6454 SendAsync net6.0 4.26μs 1.26ns 4.71ns 0.032 0 0 2.31 KB
#6454 SendAsync netcoreapp3.1 5.34μs 2.89ns 11.2ns 0.0374 0 0 2.85 KB
#6454 SendAsync net472 7.38μs 3.02ns 11.7ns 0.496 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.807ns 3.02ns 0.0225 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.07μs 3.98ns 15.4ns 0.0216 0 0 1.64 KB
master EnrichedLog net472 2.76μs 1.32ns 5.13ns 0.249 0 0 1.57 KB
#6454 EnrichedLog net6.0 1.49μs 0.806ns 3.01ns 0.0232 0 0 1.64 KB
#6454 EnrichedLog netcoreapp3.1 2.26μs 1.36ns 5.09ns 0.0224 0 0 1.64 KB
#6454 EnrichedLog net472 2.74μs 2.08ns 8.06ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 189ns 734ns 0.0574 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 141ns 545ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 144ns 557ns 0.69 0.23 0 4.46 KB
#6454 EnrichedLog net6.0 116μs 96ns 372ns 0 0 0 4.28 KB
#6454 EnrichedLog netcoreapp3.1 122μs 113ns 424ns 0 0 0 4.28 KB
#6454 EnrichedLog net472 153μs 135ns 504ns 0.684 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 0.995ns 3.85ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.18μs 1.41ns 5.44ns 0.0295 0 0 2.2 KB
master EnrichedLog net472 4.98μs 2.03ns 7.85ns 0.319 0 0 2.02 KB
#6454 EnrichedLog net6.0 3.07μs 1.33ns 5.15ns 0.0303 0 0 2.2 KB
#6454 EnrichedLog netcoreapp3.1 4.2μs 1.38ns 5.15ns 0.0294 0 0 2.2 KB
#6454 EnrichedLog net472 5μs 1.29ns 5.01ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.49μs 3.94ns 15.3ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.72μs 1.31ns 5.07ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.1μs 1.28ns 4.62ns 0.183 0 0 1.16 KB
#6454 SendReceive net6.0 1.39μs 0.601ns 2.33ns 0.016 0 0 1.14 KB
#6454 SendReceive netcoreapp3.1 1.82μs 2.57ns 9.95ns 0.0151 0 0 1.14 KB
#6454 SendReceive net472 2.13μs 1.23ns 4.76ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.66μs 1.09ns 4.22ns 0.0212 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.13μs 1.42ns 5.48ns 0.0207 0 0 1.65 KB
master EnrichedLog net472 4.24μs 2.6ns 10.1ns 0.322 0 0 2.04 KB
#6454 EnrichedLog net6.0 2.83μs 0.9ns 3.48ns 0.0227 0 0 1.6 KB
#6454 EnrichedLog netcoreapp3.1 3.85μs 2.15ns 8.06ns 0.0213 0 0 1.65 KB
#6454 EnrichedLog net472 4.24μs 3.85ns 14.9ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6454

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.122 482.04 541.09

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 396ns 0.401ns 1.5ns 0.00804 0 0 576 B
master StartFinishSpan netcoreapp3.1 564ns 1.08ns 4.19ns 0.0079 0 0 576 B
master StartFinishSpan net472 630ns 0.293ns 1.13ns 0.0916 0 0 578 B
master StartFinishScope net6.0 482ns 0.233ns 0.901ns 0.00967 0 0 696 B
master StartFinishScope netcoreapp3.1 756ns 0.288ns 1.12ns 0.0093 0 0 696 B
master StartFinishScope net472 855ns 0.595ns 2.3ns 0.104 0 0 658 B
#6454 StartFinishSpan net6.0 394ns 0.191ns 0.713ns 0.00808 0 0 576 B
#6454 StartFinishSpan netcoreapp3.1 571ns 0.387ns 1.5ns 0.00761 0 0 576 B
#6454 StartFinishSpan net472 695ns 0.59ns 2.28ns 0.0916 0 0 578 B
#6454 StartFinishScope net6.0 541ns 0.215ns 0.831ns 0.0098 0 0 696 B
#6454 StartFinishScope netcoreapp3.1 718ns 0.524ns 1.96ns 0.00916 0 0 696 B
#6454 StartFinishScope net472 831ns 0.524ns 2.03ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 737ns 0.742ns 2.87ns 0.00993 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 902ns 0.858ns 3.32ns 0.00948 0 0 696 B
master RunOnMethodBegin net472 1.08μs 0.56ns 2.17ns 0.104 0 0 658 B
#6454 RunOnMethodBegin net6.0 668ns 0.79ns 3.06ns 0.00971 0 0 696 B
#6454 RunOnMethodBegin netcoreapp3.1 918ns 0.787ns 3.05ns 0.00956 0 0 696 B
#6454 RunOnMethodBegin net472 1.16μs 0.675ns 2.61ns 0.104 0 0 658 B

@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/otel-custom-instr-telemetry branch from 58f7387 to 7a16426 Compare December 18, 2024 22:30
@zacharycmontoya zacharycmontoya changed the title Update tags for spans_created metrics [Tracing] Update telemetry metrics for OpenTelemtetry integration Dec 18, 2024
@andrewlock
Copy link
Member

andrewlock commented Dec 19, 2024 •
edited
Loading

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6454) (11.172M)   : 0, 11171561
    master (11.166M)   : 0, 11165619
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6454) (7.226M)   : 0, 7226315
    master (7.232M)   : 0, 7232435
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.555M)   : 0, 7555239

    section Manual
    master (11.218M)   : 0, 11218357

    section Manual + Automatic
    This PR (6454) (6.688M)   : 0, 6687605
    master (6.695M)   : 0, 6694720

    section DD_TRACE_ENABLED=0
    master (10.195M)   : 0, 10194994
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6454) (9.495M)   : 0, 9495307
    master (9.350M)   : 0, 9350086
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6454) (6.375M)   : 0, 6375065
    master (6.223M)   : 0, 6222880

    section Trace stats
    master (6.644M)   : 0, 6644302

    section Manual
    master (9.490M)   : 0, 9490052

    section Manual + Automatic
    This PR (6454) (5.910M)   : 0, 5909686
    master (5.826M)   : 0, 5826117

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8806093
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6454) (9.903M)   : 0, 9902503
    master (10.038M)   : 0, 10038108
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6454) (6.509M)   : 0, 6509367
    master (6.759M)   : 0, 6759031
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.327M)   : 0, 7327150

    section Manual
    master (10.148M)   : 0, 10147695

    section Manual + Automatic
    This PR (6454) (5.872M)   : crit ,0, 5872352
    master (6.270M)   : 0, 6270298

    section DD_TRACE_ENABLED=0
    master (9.572M)   : 0, 9571995
Loading

zacharycmontoya
zacharycmontoya commented Dec 19, 2024
View reviewed changes
tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/Helpers/TelemetryHelper.cs
{
spansCreatedByIntegration.Should().NotBeEmpty();

var spansCreated = spansCreatedByIntegration.Should().ContainKey($"integration_name:{integrationNameTagValue}").WhoseValue;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a new check (for all our integration tests!) that when the integration is enabled we also receive a spans_created metric that corresponds to the enabled integration.

The "otel" check above shows how this is the only integration whose tag value differs from its corresponding IntegrationId.ToString() 😅

@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/otel-custom-instr-telemetry branch from 7a16426 to b2025e7 Compare December 19, 2024 21:00
@zacharycmontoya
Add test to ensure that we are collecting spans_created metrics and a…
61bdaf9 
…sserting they have the tag "integration_name:IntegrationId.ToString()"
@zacharycmontoya
For the OpenTelemetry integration, update the tag generated for the s…
cb0a799 
…pan_created telemetry metric from `integration_name:opentelemetry` to `integration_name:otel` to align with other tracing libraries
@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/otel-custom-instr-telemetry branch from b2025e7 to cb0a799 Compare December 20, 2024 19:20
@zacharycmontoya zacharycmontoya changed the title [Tracing] Update telemetry metrics for OpenTelemtetry integration [Tracing] Update telemetry metrics for OpenTelemetry integration Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharycmontoya @andrewlock