Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelise system tests in CI #6496

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Parallelise system tests in CI #6496

wants to merge 5 commits into from

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Jan 2, 2025

Summary of changes

Set the stage of CI System Tests to 75 min.

Reason for change

It was timing out in a bunch of PRs. 75 min seems to be a good compromise of making sure the tests are not taking too much time (in case of an error) and leaves some margin for some tests that can take more than 1 hour.

@e-n-0 e-n-0 requested a review from a team as a code owner January 2, 2025 15:56
@e-n-0 e-n-0 marked this pull request as draft January 2, 2025 15:56
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 2, 2025
@e-n-0 e-n-0 force-pushed the flavien/asm/systemtests-timeout branch from 5e046e6 to 999d88a Compare January 2, 2025 16:00
@e-n-0 e-n-0 marked this pull request as ready for review January 2, 2025 16:01
@e-n-0 e-n-0 marked this pull request as draft January 2, 2025 16:18
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 2, 2025 •
edited
Loading

Datadog Report

Branch report: flavien/asm/systemtests-timeout
Commit report: 8a73064
Test service: dd-trace-dotnet

✅ 0 Failed, 232645 Passed, 2101 Skipped, 18h 30m 3.85s Total Time

@andrewlock
Copy link
Member

andrewlock commented Jan 2, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6496) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6496) - mean (976ms)  : 957, 996
     .   : milestone, 976,
    master - mean (982ms)  : 960, 1004
     .   : milestone, 982,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6496) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6496) - mean (676ms)  : 664, 689
     .   : milestone, 676,
    master - mean (675ms)  : 662, 689
     .   : milestone, 675,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6496) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6496) - mean (628ms)  : 611, 646
     .   : milestone, 628,
    master - mean (636ms)  : 623, 648
     .   : milestone, 636,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6496) - mean (193ms)  : 187, 200
     .   : milestone, 193,
    master - mean (193ms)  : 190, 197
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6496) - mean (1,104ms)  : 1072, 1137
     .   : milestone, 1104,
    master - mean (1,098ms)  : 1074, 1123
     .   : milestone, 1098,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6496) - mean (279ms)  : 273, 284
     .   : milestone, 279,
    master - mean (277ms)  : 271, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6496) - mean (869ms)  : 838, 900
     .   : milestone, 869,
    master - mean (872ms)  : 844, 901
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6496) - mean (266ms)  : 260, 273
     .   : milestone, 266,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6496) - mean (844ms)  : 812, 875
     .   : milestone, 844,
    master - mean (849ms)  : 817, 882
     .   : milestone, 849,
Loading

@andrewlock
Copy link
Member

andrewlock commented Jan 2, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6496 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.118
  • 1 benchmarks are slower, with geometric mean 1.130
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.07μs 43.9ns 335ns 0.0155 0.00774 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.3μs 53.4ns 311ns 0.021 0.0105 0 5.8 KB
master StartStopWithChild net472 16.6μs 51.4ns 199ns 1.03 0.306 0.0992 6.2 KB
#6496 StartStopWithChild net6.0 8.1μs 45.1ns 299ns 0.0171 0.00853 0 5.61 KB
#6496 StartStopWithChild netcoreapp3.1 10.2μs 50.7ns 221ns 0.0263 0.0158 0 5.8 KB
#6496 StartStopWithChild net472 16.3μs 35.9ns 129ns 1.04 0.305 0.0906 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 480μs 241ns 935ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 372ns 1.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 855μs 578ns 2.24μs 0.428 0 0 3.3 KB
#6496 WriteAndFlushEnrichedTraces net6.0 492μs 386ns 1.45μs 0 0 0 2.7 KB
#6496 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 422ns 1.63μs 0 0 0 2.7 KB
#6496 WriteAndFlushEnrichedTraces net472 857μs 666ns 2.58μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 147μs 851ns 6.91μs 0.144 0 0 14.47 KB
master SendRequest netcoreapp3.1 174μs 1.15μs 11.3μs 0.163 0 0 17.27 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6496 SendRequest net6.0 156μs 1.44μs 14.4μs 0.147 0 0 14.48 KB
#6496 SendRequest netcoreapp3.1 176μs 1.03μs 9.49μs 0.172 0 0 17.27 KB
#6496 SendRequest net472 0.00172ns 0.000845ns 0.00316ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 554μs 2.86μs 13.4μs 0.539 0 0 41.54 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 3.37μs 16.2μs 0.317 0 0 41.77 KB
master WriteAndFlushEnrichedTraces net472 850μs 2.53μs 9.46μs 8.17 2.45 0.408 53.26 KB
#6496 WriteAndFlushEnrichedTraces net6.0 568μs 3.05μs 22.8μs 0.541 0 0 41.61 KB
#6496 WriteAndFlushEnrichedTraces netcoreapp3.1 703μs 4.03μs 31.5μs 0.334 0 0 41.74 KB
#6496 WriteAndFlushEnrichedTraces net472 885μs 4.6μs 31.5μs 8.08 2.55 0.425 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.24μs 1.14ns 4.42ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.85μs 1.79ns 6.7ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 2.04ns 7.91ns 0.157 0.00108 0 987 B
#6496 ExecuteNonQuery net6.0 1.35μs 1.58ns 6.1ns 0.0142 0 0 1.02 KB
#6496 ExecuteNonQuery netcoreapp3.1 1.85μs 3.31ns 12.8ns 0.0139 0 0 1.02 KB
#6496 ExecuteNonQuery net472 2.03μs 2.03ns 7.86ns 0.156 0.00101 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6496

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.118 1,347.37 1,205.01

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.15μs 0.479ns 1.86ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 0.752ns 2.71ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.51μs 1.08ns 4.18ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 0.581ns 2.25ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 1.38ns 5.35ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.59μs 0.919ns 3.44ns 0.167 0 0 1.05 KB
#6496 CallElasticsearch net6.0 1.24μs 0.52ns 1.94ns 0.014 0 0 976 B
#6496 CallElasticsearch netcoreapp3.1 1.53μs 0.649ns 2.43ns 0.0132 0 0 976 B
#6496 CallElasticsearch net472 2.5μs 1.08ns 4.17ns 0.157 0 0 995 B
#6496 CallElasticsearchAsync net6.0 1.21μs 0.884ns 3.31ns 0.0133 0 0 952 B
#6496 CallElasticsearchAsync netcoreapp3.1 1.69μs 1.17ns 4.52ns 0.0136 0 0 1.02 KB
#6496 CallElasticsearchAsync net472 2.57μs 0.83ns 3.21ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.35μs 0.574ns 2.15ns 0.0129 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 0.749ns 2.7ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.83μs 0.493ns 1.91ns 0.145 0 0 915 B
#6496 ExecuteAsync net6.0 1.27μs 0.509ns 1.91ns 0.0134 0 0 952 B
#6496 ExecuteAsync netcoreapp3.1 1.57μs 0.476ns 1.78ns 0.0126 0 0 952 B
#6496 ExecuteAsync net472 1.78μs 0.634ns 2.37ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.38μs 2.2ns 7.62ns 0.0329 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.29μs 1.51ns 5.46ns 0.0372 0 0 2.85 KB
master SendAsync net472 7.4μs 1.96ns 7.61ns 0.495 0 0 3.12 KB
#6496 SendAsync net6.0 4.58μs 2ns 7.76ns 0.0319 0 0 2.31 KB
#6496 SendAsync netcoreapp3.1 5.29μs 2.91ns 10.9ns 0.0371 0 0 2.85 KB
#6496 SendAsync net472 7.31μs 1.53ns 5.92ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 0.556ns 2.08ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.3μs 1.32ns 4.75ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.69μs 1.45ns 5.6ns 0.249 0 0 1.57 KB
#6496 EnrichedLog net6.0 1.56μs 0.621ns 2.24ns 0.0228 0 0 1.64 KB
#6496 EnrichedLog netcoreapp3.1 2.23μs 1.34ns 5.17ns 0.0223 0 0 1.64 KB
#6496 EnrichedLog net472 2.61μs 1.76ns 6.59ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 128ns 495ns 0.0584 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 362ns 1.4μs 0 0 0 4.28 KB
master EnrichedLog net472 153μs 127ns 494ns 0.681 0.227 0 4.46 KB
#6496 EnrichedLog net6.0 118μs 112ns 433ns 0.059 0 0 4.28 KB
#6496 EnrichedLog netcoreapp3.1 123μs 188ns 728ns 0 0 0 4.28 KB
#6496 EnrichedLog net472 153μs 133ns 517ns 0.689 0.23 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.01μs 1.69ns 6.31ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.18μs 3.35ns 13ns 0.0292 0 0 2.2 KB
master EnrichedLog net472 4.87μs 1.55ns 5.58ns 0.32 0 0 2.02 KB
#6496 EnrichedLog net6.0 2.99μs 1.42ns 5.52ns 0.0315 0 0 2.2 KB
#6496 EnrichedLog netcoreapp3.1 4.25μs 1.56ns 5.84ns 0.03 0 0 2.2 KB
#6496 EnrichedLog net472 4.98μs 1.24ns 4.64ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 1.97ns 7.62ns 0.0156 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 0.812ns 3.14ns 0.0159 0 0 1.14 KB
master SendReceive net472 2.12μs 1.56ns 6.03ns 0.183 0 0 1.16 KB
#6496 SendReceive net6.0 1.47μs 0.954ns 3.69ns 0.0161 0 0 1.14 KB
#6496 SendReceive netcoreapp3.1 1.78μs 0.833ns 3.12ns 0.015 0 0 1.14 KB
#6496 SendReceive net472 2.2μs 0.882ns 3.3ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.666ns 2.4ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 1.44ns 5.56ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.46μs 7.23ns 28ns 0.323 0 0 2.04 KB
#6496 EnrichedLog net6.0 2.78μs 0.835ns 3.13ns 0.0221 0 0 1.6 KB
#6496 EnrichedLog netcoreapp3.1 3.96μs 1.87ns 7.25ns 0.0217 0 0 1.65 KB
#6496 EnrichedLog net472 4.27μs 2.92ns 10.9ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6496

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.130 659.21 744.78

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 391ns 0.165ns 0.594ns 0.00809 0 0 576 B
master StartFinishSpan netcoreapp3.1 599ns 0.905ns 3.51ns 0.00774 0 0 576 B
master StartFinishSpan net472 697ns 0.592ns 2.29ns 0.0917 0 0 578 B
master StartFinishScope net6.0 520ns 0.267ns 1.04ns 0.00977 0 0 696 B
master StartFinishScope netcoreapp3.1 660ns 0.483ns 1.81ns 0.00929 0 0 696 B
master StartFinishScope net472 869ns 0.66ns 2.56ns 0.105 0 0 658 B
#6496 StartFinishSpan net6.0 413ns 0.218ns 0.844ns 0.00807 0 0 576 B
#6496 StartFinishSpan netcoreapp3.1 570ns 1.74ns 6.73ns 0.00788 0 0 576 B
#6496 StartFinishSpan net472 670ns 0.353ns 1.37ns 0.0917 0 0 578 B
#6496 StartFinishScope net6.0 547ns 0.152ns 0.55ns 0.00985 0 0 696 B
#6496 StartFinishScope netcoreapp3.1 745ns 0.238ns 0.825ns 0.00935 0 0 696 B
#6496 StartFinishScope net472 848ns 0.703ns 2.72ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 646ns 0.399ns 1.54ns 0.00981 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 954ns 0.985ns 3.82ns 0.00959 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.645ns 2.5ns 0.104 0 0 658 B
#6496 RunOnMethodBegin net6.0 617ns 0.449ns 1.74ns 0.00987 0 0 696 B
#6496 RunOnMethodBegin netcoreapp3.1 1.04μs 0.767ns 2.97ns 0.00932 0 0 696 B
#6496 RunOnMethodBegin net472 1.12μs 0.611ns 2.37ns 0.104 0 0 658 B

@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:docs area:tests unit tests, integration tests area:opentracing area:installers area:vendors Code from other vendors area:shared-components area:profiler Issues related to the continous-profiler area:debugger area:integrations labels Jan 3, 2025
@e-n-0 e-n-0 removed area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:docs area:tests unit tests, integration tests area:opentracing area:installers area:vendors Code from other vendors area:shared-components area:profiler Issues related to the continous-profiler area:debugger labels Jan 3, 2025
@e-n-0 e-n-0 force-pushed the flavien/asm/systemtests-timeout branch 4 times, most recently from a4888af to dd65986 Compare January 3, 2025 14:20
@e-n-0 e-n-0 changed the title Increase system tests timeout to 75 min Parallelise system tests in CI Jan 3, 2025
@e-n-0 e-n-0 force-pushed the flavien/asm/systemtests-timeout branch 6 times, most recently from 57cccf3 to 078a37d Compare January 4, 2025 13:21
@e-n-0 e-n-0 force-pushed the flavien/asm/systemtests-timeout branch 2 times, most recently from 8cd9e80 to b80f73e Compare January 4, 2025 20:17
@e-n-0 e-n-0 force-pushed the flavien/asm/systemtests-timeout branch from b80f73e to 8a73064 Compare January 4, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-0 @andrewlock