-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to the new domains / URLs from Microsoft in dotnet-install
#6574
Conversation
See: dotnet/core#9671 They are changing CDNs. These changes have already been added in the official install scripts. https://github.com/dotnet/install-scripts/pull/555/files
Looks like a duplicate of #6484? |
Expected that the old domains will cease to work March 31st 2025
Ha yep thanks didn't see that one 😅 I'll close this one |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6574) - mean (69ms) : 66, 71
. : milestone, 69,
master - mean (71ms) : 67, 74
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6574) - mean (985ms) : 963, 1007
. : milestone, 985,
master - mean (984ms) : 958, 1009
. : milestone, 984,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6574) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6574) - mean (680ms) : 666, 694
. : milestone, 680,
master - mean (683ms) : 670, 696
. : milestone, 683,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6574) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 90, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6574) - mean (634ms) : 616, 651
. : milestone, 634,
master - mean (635ms) : 617, 653
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6574) - mean (192ms) : 187, 196
. : milestone, 192,
master - mean (191ms) : 186, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6574) - mean (1,092ms) : 1058, 1127
. : milestone, 1092,
master - mean (1,092ms) : 1066, 1118
. : milestone, 1092,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6574) - mean (276ms) : 272, 281
. : milestone, 276,
master - mean (275ms) : 271, 279
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6574) - mean (866ms) : 835, 897
. : milestone, 866,
master - mean (870ms) : 840, 900
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6574) - mean (265ms) : 261, 270
. : milestone, 265,
master - mean (264ms) : 261, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (6574) - mean (850ms) : 821, 880
. : milestone, 850,
master - mean (848ms) : 819, 877
. : milestone, 848,
|
Summary of changes
Changes our copies of
dotnet-install.ps1
anddotnet-install.sh
to point to the new feeds.Reason for change
Microsoft is moving to a new CDN for these and they require new URLs. See: dotnet/core#9671
Implementation details
Followed
User Remediation
defined in dotnet/core#9671 (comment)Test coverage
Other details
These changes have already been added in the official install scripts. However it looks like they've been added in addition to the old URLs, I wasn't sure if we needed to do that or not.
https://github.com/dotnet/install-scripts/pull/555/files